#2212 closed defect (fixed)

warnings in Beagle BSPs

Reported by: Joel Sherrill Owned by: Ben Gras
Priority: high Milestone: 4.11
Component: bsps Version: 4.11
Severity: blocker Keywords:
Cc: Blocked By:
Blocking:

Description

Clean up request. The console ones appear to be that the rtems/console.h is not included from libbsp/shared/console_* files used. It must be included by something else in other cases.

[joel@rtbf64a rtems]$ grep beagle warnings-per-bsp-20141208a.txt warnings-20141208a.txt
warnings-per-bsp-20141208a.txt:9 arm-beagleboneblack (inBSP=5 inLibCPU=0)
warnings-per-bsp-20141208a.txt:9 arm-beaglebonewhite (inBSP=5 inLibCPU=0)
warnings-per-bsp-20141208a.txt:10 arm-beagleboardorig (inBSP=6 inLibCPU=0)
warnings-per-bsp-20141208a.txt:10 arm-beagleboardxm (inBSP=6 inLibCPU=0)
warnings-20141208a.txt: 4 c/src/lib/libbsp/arm/beagle/../../shared/console_write.c:36:21: warning: no previous prototype for 'console_write' [-Wmissing-prototypes]
warnings-20141208a.txt: 4 c/src/lib/libbsp/arm/beagle/../../shared/console_read.c:36:21: warning: no previous prototype for 'console_read' [-Wmissing-prototypes]
warnings-20141208a.txt: 4 c/src/lib/libbsp/arm/beagle/../../shared/console_control.c:37:21: warning: no previous prototype for 'console_control' [-Wmissing-prototypes]
warnings-20141208a.txt: 4 c/src/lib/libbsp/arm/beagle/irq.c:139:36: warning: passing argument 1 of 'arm_cp15_set_vector_base_address' makes pointer from integer without a cast
warnings-20141208a.txt: 4 c/src/lib/libbsp/arm/beagle/clock.c:267:12: warning: unused variable 'tisr' [-Wunused-variable]
warnings-20141208a.txt: 2 c/src/lib/libbsp/arm/beagle/clock.c:48:31: warning: 'regs_v2' defined but not used [-Wunused-variable]

Change History (3)

comment:1 Changed on Dec 15, 2014 at 12:49:49 PM by Ben Gras

A patch to mainline to solve these has been submitted.

http://lists.rtems.org/pipermail/devel/2014-December/009607.html

comment:2 Changed on Dec 15, 2014 at 6:32:57 PM by Ben Gras <beng@…>

In 1e587f7d6d76bbe4baf3ec403ac6ed9bffc58f62/rtems:

bsp/beagle: Fix some warnings

The extra includes in console_*.c are to solve a 'no previous prototype'
warning.

Solves #2212 in trac.

comment:3 Changed on Dec 15, 2014 at 6:40:42 PM by Ben Gras

Resolution: fixed
Status: newclosed

the commit solves this issue - i hope @joel can confirm.

Note: See TracTickets for help on using tickets.