Opened on 08/09/13 at 00:29:12
Closed on 12/10/13 at 03:02:36
#2138 closed defect (fixed)
[PATCH] rtems_rfs_rtems_initialize() can erroneously set errno to rtems_rfs_fs_open()'s return value (-1 in the error case); violates spec
Reported by: | Nick Withers | Owned by: | Chris Johns |
---|---|---|---|
Priority: | normal | Milestone: | 4.11 |
Component: | fs | Version: | 4.11 |
Severity: | normal | Keywords: | |
Cc: | nick.withers@… | Blocked By: | |
Blocking: |
Description
rtems_rfs_fs_open() returns -1 in the event of a detected error, setting errno to indicate the cause. rtems_rfs_rtems_initialize() then erroneously sets errno to be the return value instead.
P.S.: The attached patch fixes handling only for this particular error case, but a quick glance suggests there may be more opportunities for rtems_rfs_rtems_initialize() to not set errno correctly
Attachments (1)
Change History (5)
Changed on 08/09/13 at 00:29:12 by Nick Withers
Attachment: | rtems-rfs-rtems.c.patch added |
---|
comment:1 Changed on 08/09/13 at 04:21:16 by Nick Withers
Summary: | [PATCH] rtems_rfs_rtems_initialize() can erroneously set errno to rtems_rfs_fs_open()'s return value (-1 in the error); violates spec → [PATCH] rtems_rfs_rtems_initialize() can erroneously set errno to rtems_rfs_fs_open()'s return value (-1 in the error case); violates spec |
---|
comment:2 Changed on 08/09/13 at 04:22:07 by Nick Withers
Cc: | Nick Withers added |
---|
comment:3 Changed on 12/10/13 at 03:02:36 by Chris Johns
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 Changed on 11/24/14 at 18:58:28 by Gedare Bloom
Version: | HEAD → 4.11 |
---|
Replace Version=HEAD with Version=4.11 for the tickets with Milestone >= 4.11
Note: See
TracTickets for help on using
tickets.
Supply errno (set by rtems_rfs_fs_open()) to rtems_rfs_rtems_error() when rtems_rfs_fs_open() fails, rather than it's -1 return value