Opened on 04/07/13 at 14:02:35
Closed on 11/23/14 at 16:03:13
#2113 closed defect
sparc/leon2 - incorrect include for <ringbuf.h>
Reported by: | Joel Sherrill | Owned by: | Joel Sherrill |
---|---|---|---|
Priority: | normal | Milestone: | 4.11 |
Component: | bsps | Version: | 4.11 |
Severity: | normal | Keywords: | |
Cc: | Blocked By: | ||
Blocking: |
Description (last modified by Joel Sherrill)
Reported http://www.rtems.org/pipermail/rtems-users/2013-April/011253.html
Likely to impact older versions so filing a tracking PR. The code needs to change from <ringbuf.h> to <rtems/ringbuf.h>.
I believe there may be a problem with the bsp code for leon2 bsp. When
configured with 'CONSOLE_USE_INTERRUPTS=1' the resulting make will result in
a file not found error for 'ringbuf.h' for the compile of the file
'c/src/lib/libbsp/sparc/leon2/console/console.c'.
b-leon2 Config:
../rtems-4.11/configure --target=sparc-rtems \
--enable-rtemsbsp=leon2 \
--prefix=<rtems-install> --enable-posix \
CONSOLE_USE_INTERRUPTS=1
To work around the issue I revised 'console.c ' line 73 from
#include <ringbuf.h>
To
#include <rtems/ringbuf.h>
Change History (4)
comment:1 Changed on 04/07/13 at 14:02:35 by Joel Sherrill
comment:2 Changed on 11/23/14 at 15:47:20 by Joel Sherrill
Description: | modified (diff) |
---|---|
Version: | unknown → 4.11 |
<ringbuf.h> was moved to <rtems/ringbug.h> in 2011 and apparently the person who made the change didn't run grep.
comment:3 Changed on 11/23/14 at 15:48:58 by Joel Sherrill <joel.sherrill@…>
comment:4 Changed on 11/23/14 at 16:03:13 by Joel Sherrill
Resolution: | → fixed |
---|---|
Status: | new → closed |
Reported http://www.rtems.org/pipermail/rtems-users/2013-April/011253.html
Likely to impact older versions so filing a tracking PR. The code needs to change from <ringbuf.h> to <rtems/ringbuf.h>.
I believe there may be a problem with the bsp code for leon2 bsp. When
configured with 'CONSOLE_USE_INTERRUPTS=1' the resulting make will result in
a file not found error for 'ringbuf.h' for the compile of the file
'c/src/lib/libbsp/sparc/leon2/console/console.c'.
b-leon2 Config:
../rtems-4.11/configure --target=sparc-rtems \
--enable-rtemsbsp=leon2 \
--prefix=<rtems-install> --enable-posix \
CONSOLE_USE_INTERRUPTS=1
To work around the issue I revised 'console.c ' line 73 from
#include <ringbuf.h>
To
#include <rtems/ringbuf.h>