#2113 closed defect

sparc/leon2 - incorrect include for <ringbuf.h>

Reported by: Joel Sherrill Owned by: Joel Sherrill
Priority: normal Milestone: 4.11
Component: bsps Version: 4.11
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description (last modified by Joel Sherrill)

Reported http://www.rtems.org/pipermail/rtems-users/2013-April/011253.html

Likely to impact older versions so filing a tracking PR. The code needs to change from <ringbuf.h> to <rtems/ringbuf.h>.

I believe there may be a problem with the bsp code for leon2 bsp. When
configured with 'CONSOLE_USE_INTERRUPTS=1' the resulting make will result in
a file not found error for 'ringbuf.h' for the compile of the file
'c/src/lib/libbsp/sparc/leon2/console/console.c'.

b-leon2 Config:
../rtems-4.11/configure --target=sparc-rtems \
--enable-rtemsbsp=leon2 \
--prefix=<rtems-install> --enable-posix \
CONSOLE_USE_INTERRUPTS=1

To work around the issue I revised 'console.c ' line 73 from

#include <ringbuf.h>

To

#include <rtems/ringbuf.h>

Change History (4)

comment:1 Changed on Apr 7, 2013 at 2:02:35 PM by Joel Sherrill

Reported http://www.rtems.org/pipermail/rtems-users/2013-April/011253.html

Likely to impact older versions so filing a tracking PR. The code needs to change from <ringbuf.h> to <rtems/ringbuf.h>.

I believe there may be a problem with the bsp code for leon2 bsp. When
configured with 'CONSOLE_USE_INTERRUPTS=1' the resulting make will result in
a file not found error for 'ringbuf.h' for the compile of the file
'c/src/lib/libbsp/sparc/leon2/console/console.c'.

b-leon2 Config:
../rtems-4.11/configure --target=sparc-rtems \
--enable-rtemsbsp=leon2 \
--prefix=<rtems-install> --enable-posix \
CONSOLE_USE_INTERRUPTS=1

To work around the issue I revised 'console.c ' line 73 from

#include <ringbuf.h>

To

#include <rtems/ringbuf.h>

comment:2 Changed on Nov 23, 2014 at 3:47:20 PM by Joel Sherrill

Description: modified (diff)
Version: unknown4.11

<ringbuf.h> was moved to <rtems/ringbug.h> in 2011 and apparently the person who made the change didn't run grep.

comment:3 Changed on Nov 23, 2014 at 3:48:58 PM by Joel Sherrill <joel.sherrill@…>

In b46a31e0b84338844a701dacbafabb4791228114/rtems:

leon2: include <rtems/ringbuf.h> not <ringbuf.h>

close #2113

comment:4 Changed on Nov 23, 2014 at 4:03:13 PM by Joel Sherrill

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.