#2073 closed enhancement (wontfix)

Unnecessary check for alignment and unreachable code in cpukit/score/src/coremsg.c

Reported by: Krzysztof Miesowicz Owned by: Joel Sherrill
Priority: normal Milestone: 4.11
Component: score Version: 4.10
Severity: minor Keywords:
Cc: gedare@… Blocked By:
Blocking:

Description

When analyzing coverage report http://www.rtems.org/ftp/pub/rtems/people/joel/coverage/erc32/erc32-Ospd-20120714-1625/annotated.html#range2 I discovered that there is unreachable and unnecessary if-statement. It gives 2 uncovered instructions. Checking if allocated_message_size is less than maximum_message_size is unnecessary as above code guarantee that allocated_message_size will be equal or greater than maximum_message_size.

I am sending patch as attachment.

Attachments (1)

removing unreachable code in coremsg (1.2 KB) - added by Krzysztof Miesowicz on Aug 15, 2012 at 8:16:21 AM.
Patch to remove unreachable code in coremsg.c

Download all attachments as: .zip

Change History (3)

Changed on Aug 15, 2012 at 8:16:21 AM by Krzysztof Miesowicz

Patch to remove unreachable code in coremsg.c

comment:1 Changed on Aug 15, 2012 at 1:06:32 PM by Gedare Bloom

attachments.ispatch: 01
attachments.mimetype: application/octet-streamtext/plain

comment:2 Changed on Dec 3, 2013 at 3:03:39 PM by Gedare Bloom

Resolution: wontfix
Status: newclosed, gedare@rtems.org
Note: See TracTickets for help on using tickets.