#2056 closed defect (fixed)

libqos conversion from uint32_t to time_t

Reported by: Gedare Bloom Owned by: Joel Sherrill
Priority: normal Milestone: 4.11
Component: score Version: 4.11
Severity: normal Keywords:
Cc: ralf.corsepius@…, petben@… Blocked By:
Blocking:

Description

I think there is a casting in libqos that assumes time_t is equivalent to uint32_t.

In schedulercbs.h we have
typedef struct {

/ Relative deadline of the server. */
time_t deadline;
/
Budget (computation time) of the server. */
time_t budget;

} Scheduler_CBS_Parameters;

In qreslib.h we have
typedef struct {

/ Relative deadline of the server. */
uint32_t P;
/
Budget (computation time) of the server. */
uint32_t Q;

} qres_params_t;

RTEMS_INLINE_ROUTINE qos_rv qres_create_server (

qres_params_t *params,
qres_sid_t *server_id

)
{

return _Scheduler_CBS_Create_server(

(Scheduler_CBS_Parameters *) params,
NULL,
server_id

);

}

Looking at the AquosA api http://aquosa.sourceforge.net/aquosa-docs/aquosa-qosres/html/ I think we should be defining the qres_params_t in terms of qres_time_t instead of uint32_t, which means the structures should be identical.

I think we can fix this just by typedef Scheduler_CBS_Parameters qres_params_t;

Attachments (1)

0001-PR2056-libqos-conversion-from-uint32_t-to-time_t.patch (882 bytes) - added by Gedare Bloom on Apr 23, 2012 at 12:58:51 PM.
fix qres_params_t

Download all attachments as: .zip

Change History (5)

comment:1 Changed on Apr 23, 2012 at 12:50:28 PM by Gedare Bloom

Cc: Petr Benes added

Changed on Apr 23, 2012 at 12:58:51 PM by Gedare Bloom

fix qres_params_t

comment:2 Changed on Apr 23, 2012 at 2:43:02 PM by Ralf Corsepius

Cc: Ralf Corsepius added

comment:4 Changed on Nov 24, 2014 at 6:58:28 PM by Gedare Bloom

Version: HEAD4.11

Replace Version=HEAD with Version=4.11 for the tickets with Milestone >= 4.11

Note: See TracTickets for help on using tickets.