#2024 assigned defect

A patch to support additional parameter passing via DHCP

Reported by: Ric Claus Owned by: Joel Sherrill
Priority: normal Milestone: 4.9.5
Component: network/legacy Version: 4.9
Severity: normal Keywords:
Cc: chrisj@…, claus@… Blocked By:
Blocking:

Description

This set of modifications was produced a few years ago and I am not the author. However, they provide additional functionality to the basic DHCP support in RTEMS, which I figure someone else might find useful. If this appears to be of interest, we would welcome its being incorporated into RTEMS.

Attachments (1)

0003-Modified-to-allow-DHCP-to-pass-additional-parameters.patch (20.8 KB) - added by Ric Claus on Feb 17, 2012 at 10:17:33 PM.
DHCP parameter passing patch

Download all attachments as: .zip

Change History (5)

Changed on Feb 17, 2012 at 10:17:33 PM by Ric Claus

DHCP parameter passing patch

comment:1 Changed on Feb 18, 2012 at 5:24:38 PM by Ric Claus

Cc: Ric Claus added

comment:2 Changed on Feb 26, 2012 at 9:03:52 PM by Chris Johns

Cc: Chris Johns added

comment:3 Changed on Feb 27, 2012 at 5:06:42 PM by Ric Claus

Replying to comment:2:

The addition of vendor options with a callback is nice. I do have some
questions.

  1. The call dhcp_init has changed and I suspect this could break existing user

code. Should the dhcp_init call remain the same a new call added, eg
dhcp_init_ex or dhcp_init_vendor ?

Yes, on the face of it, I would agree. Perhaps dhcp_init could be a jacket around dhcp_init_ex...

2.
https://www.rtems.org/bugzilla/attachment.cgi?id=1438&action=diff#a/cpukit/libnetworking/rtems/rtems_dhcp.c_sec24
: What are the '& 1' and '& 2' bits handling ? I would rather see define labels
for the bits.

Did you mean at here?
https://www.rtems.org/bugzilla/attachment.cgi?id=1438&action=diff#a/cpukit/libnetworking/rtems/rtems_dhcp.c_sec31

Yes, Iagree, but would have to look into it. However, it's that way in the original, if we're talking about the same thing.

3.
https://www.rtems.org/bugzilla/attachment.cgi?id=1438&action=diff#a/cpukit/libnetworking/rtems/rtems_dhcp.c_sec37
: Is this a new feature to handle more interfaces ?

Yes, that's what we used it for. I can provide example usage code and dhcp.conf snipptes, if you're interested.

comment:4 Changed on Nov 22, 2014 at 2:37:22 PM by Gedare

Milestone: 4.114.9.5
Owner: changed from Eric Norum to Joel Sherrill
Status: newassigned
Version: 4.104.9
Note: See TracTickets for help on using tickets.