Opened on 02/17/12 at 22:16:37
Last modified on 02/27/12 at 17:06:42
#2024 assigned defect
A patch to support additional parameter passing via DHCP
Reported by: | Ric Claus | Owned by: | Joel Sherrill |
---|---|---|---|
Priority: | normal | Milestone: | 4.9.5 |
Component: | network/legacy | Version: | 4.9 |
Severity: | normal | Keywords: | |
Cc: | chrisj@…, claus@… | Blocked By: | |
Blocking: |
Description
This set of modifications was produced a few years ago and I am not the author. However, they provide additional functionality to the basic DHCP support in RTEMS, which I figure someone else might find useful. If this appears to be of interest, we would welcome its being incorporated into RTEMS.
Attachments (1)
Change History (5)
Changed on 02/17/12 at 22:17:33 by Ric Claus
Attachment: | 0003-Modified-to-allow-DHCP-to-pass-additional-parameters.patch added |
---|
comment:1 Changed on 02/18/12 at 17:24:38 by Ric Claus
Cc: | Ric Claus added |
---|
comment:2 Changed on 02/26/12 at 21:03:52 by Chris Johns
Cc: | Chris Johns added |
---|
comment:3 Changed on 02/27/12 at 17:06:42 by Ric Claus
Replying to comment:2:
The addition of vendor options with a callback is nice. I do have some
questions.
- The call dhcp_init has changed and I suspect this could break existing user
code. Should the dhcp_init call remain the same a new call added, eg
dhcp_init_ex or dhcp_init_vendor ?
Yes, on the face of it, I would agree. Perhaps dhcp_init could be a jacket around dhcp_init_ex...
2.
https://www.rtems.org/bugzilla/attachment.cgi?id=1438&action=diff#a/cpukit/libnetworking/rtems/rtems_dhcp.c_sec24
: What are the '& 1' and '& 2' bits handling ? I would rather see define labels
for the bits.
Did you mean at here?
https://www.rtems.org/bugzilla/attachment.cgi?id=1438&action=diff#a/cpukit/libnetworking/rtems/rtems_dhcp.c_sec31
Yes, Iagree, but would have to look into it. However, it's that way in the original, if we're talking about the same thing.
3.
https://www.rtems.org/bugzilla/attachment.cgi?id=1438&action=diff#a/cpukit/libnetworking/rtems/rtems_dhcp.c_sec37
: Is this a new feature to handle more interfaces ?
Yes, that's what we used it for. I can provide example usage code and dhcp.conf snipptes, if you're interested.
comment:4 Changed on 11/22/14 at 14:37:22 by Gedare Bloom
Milestone: | 4.11 → 4.9.5 |
---|---|
Owner: | changed from Eric Norum to Joel Sherrill |
Status: | new → assigned |
Version: | 4.10 → 4.9 |
DHCP parameter passing patch