![[RTEMS Logo]](/images/logo.png){kind=logo}
#1975 closed defect (fixed)
c/src/libchip/ide/ata.c:424:25: warning: variable 'dev' set but not used
| Reported by: | Ralf Corsepius | Owned by: | Joel Sherrill |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.11 |
| Component: | unspecified | Version: | 4.11 |
| Severity: | normal | Keywords: | |
| Cc: | chrisj@…, sebastian.huber@… | Blocked By: | |
| Blocking: |
Description
GCC raises these warnings:
c/src/libchip/ide/ata.c:424:25: warning: variable 'dev' set but not used
c/src/libchip/ide/ata.c:746:21: warning: variable 'dev' set but not used
c/src/libchip/ide/ata.c:790:21: warning: variable 'dev' set but not used
All these places condense to this:
...
uint8_t i, dev;
...
/* get ATA device identifier (0 or 1) */
dev = areq->regs.regs[IDE_REGISTER_DEVICE_HEAD] &
IDE_REGISTER_DEVICE_HEAD_DEV;
...
[dev is not being used later on]
Looks like a non-completed attempt to support primary/secondary ata devices to me, which in its present shape doesn't have any function.
No idea what to do about this - Simpliest, least intrusive measure would be to "#ifdef 0" out these questionable places.
Change History (5)
comment:1 Changed on 11/30/11 at 17:22:25 by Ralf Corsepius
| Cc: | Sebastian Huber added |
|---|
comment:2 Changed on 12/05/11 at 00:51:03 by Chris Johns
| Cc: | Chris Johns added |
|---|
comment:3 Changed on 12/05/11 at 08:24:16 by Sebastian Huber
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 Changed on 11/24/14 at 18:58:28 by Gedare Bloom
| Version: | HEAD → 4.11 |
|---|
Replace Version=HEAD with Version=4.11 for the tickets with Milestone >= 4.11
comment:5 Changed on 10/10/17 at 06:35:44 by Sebastian Huber
| Component: | misc → unspecified |
|---|
I disabled these assignments with "#if 0". This ATA support has so many issues, it is a waste of time to improve it.