#1692 closed defect (fixed)

rtems_libio_is_valid_perms is broken

Reported by: Joel Sherrill Owned by: Chris Johns
Priority: normal Milestone: 4.11
Component: fs Version: 4.11
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

Coverity pointed out that the implementation evaluated to a constant. This impacted the implementation of this method. In discussing the fix, it was pointed out that when checking the result of this test, we should return EPERM not EIO.

This was pointed out by at least the following CIDs.

http://scan2.coverity.com:9104/cov.cgi?cid=54
http://scan2.coverity.com:9104/cov.cgi?cid=55
http://scan2.coverity.com:9104/cov.cgi?cid=56

Attachments (5)

pr1692.diff (1.5 KB) - added by Joel Sherrill on Aug 27, 2010 at 4:19:00 PM.
Fix for head
pr1692-r11.diff (2.1 KB) - added by Joel Sherrill on Aug 27, 2010 at 4:35:00 PM.
Patch for 4.11
pr1692-r10.diff (2.1 KB) - added by Joel Sherrill on Aug 27, 2010 at 4:35:18 PM.
Patch for 4.10
pr1692-r9.diff (1.3 KB) - added by Joel Sherrill on Aug 27, 2010 at 4:35:40 PM.
Patch for 4.9
pr1692-r8.diff (1.3 KB) - added by Joel Sherrill on Aug 27, 2010 at 4:35:57 PM.
Patch for 4.8

Download all attachments as: .zip

Change History (8)

Changed on Aug 27, 2010 at 4:19:00 PM by Joel Sherrill

Attachment: pr1692.diff added

Fix for head

Changed on Aug 27, 2010 at 4:35:00 PM by Joel Sherrill

Attachment: pr1692-r11.diff added

Patch for 4.11

comment:1 Changed on Aug 27, 2010 at 4:35:00 PM by Joel Sherrill

attachments.isobsolete: 01

Changed on Aug 27, 2010 at 4:35:18 PM by Joel Sherrill

Attachment: pr1692-r10.diff added

Patch for 4.10

Changed on Aug 27, 2010 at 4:35:40 PM by Joel Sherrill

Attachment: pr1692-r9.diff added

Patch for 4.9

Changed on Aug 27, 2010 at 4:35:57 PM by Joel Sherrill

Attachment: pr1692-r8.diff added

Patch for 4.8

comment:2 Changed on Aug 27, 2010 at 4:38:05 PM by Joel Sherrill

Resolution: fixed
Status: newclosed

Patches committed.

comment:3 Changed on Nov 24, 2014 at 6:58:28 PM by Gedare Bloom

Version: HEAD4.11

Replace Version=HEAD with Version=4.11 for the tickets with Milestone >= 4.11

Note: See TracTickets for help on using tickets.