#1624 closed defect (fixed)

TFTPFS not parsing hostnames & paths correctly

Reported by: Angus Gratton Owned by: Chris Johns
Priority: normal Milestone: 4.10
Component: fs Version: 4.10
Severity: normal Keywords:
Cc: sebastian.huber@…, dylan.maxwell@… Blocked By:
Blocking:

Description

TFTPFS doesn't successfully parse paths correctly to hostname & file. Issue seen in 4.10 and looks the same in CVS HEAD.

I'm using PowerPC MVME3100 board, although I think this problem is non-board-specific. However, one bug will not be seen if strlen(NULL) is always zero (this is an undefined result on RTEMS PowerPC.)

To reproduce, you can use the network-demos/tftpTest application and configure it with non-BootP TFTP host and filename. No files will be successfully requested.

I've attached a patch with the fixes that I think are necessary.

I also noticed a secondary issue: if you access files as /TFTP/BOOTP_HOST/ then it looks like there may also be another problem parsing the file, because the 'cp1' variable is not set properly in tftpDriver.c. The patch includes a one-line fix for that as well, although I haven't tested that particular case myself.

Hth. Apologies for any bad formatting/deviant code style. Cheers - Angus

Attachments (2)

tftp-patch-1.diff (955 bytes) - added by Angus Gratton on Jul 20, 2010 at 4:04:07 AM.
Patch to fix TFTPFS on RTEMS 4.10
rtems-4.10-Bug1624.diff (1.8 KB) - added by Dylan Maxwell on Jun 6, 2012 at 8:51:51 PM.
Patch to fix TFTPFS on RTEMS 4.10 (v2)

Download all attachments as: .zip

Change History (9)

Changed on Jul 20, 2010 at 4:04:07 AM by Angus Gratton

Attachment: tftp-patch-1.diff added

Patch to fix TFTPFS on RTEMS 4.10

comment:1 Changed on Jul 20, 2010 at 11:42:27 PM by Chris Johns

Status: newassigned

comment:2 Changed on Jul 20, 2010 at 11:43:46 PM by Chris Johns

blocked: 1625

comment:3 Changed on May 22, 2012 at 8:12:33 AM by Sebastian Huber

Cc: Sebastian Huber added

comment:4 Changed on Jun 5, 2012 at 2:07:17 PM by Dylan Maxwell

Cc: Dylan Maxwell added

Changed on Jun 6, 2012 at 8:51:51 PM by Dylan Maxwell

Attachment: rtems-4.10-Bug1624.diff added

Patch to fix TFTPFS on RTEMS 4.10 (v2)

comment:5 Changed on Jun 6, 2012 at 8:51:51 PM by Dylan Maxwell

attachments.isobsolete: 01

comment:7 Changed on Dec 6, 2012 at 7:52:39 AM by Sebastian Huber

Milestone: 4.114.10
Note: See TracTickets for help on using tickets.