Opened on 03/22/02 at 07:38:00

Closed on 03/27/02 at 13:36:33

Last modified on 10/10/17 at 06:37:47

#162 closed defect (fixed)

ppp patch

Reported by: Ilya Alexeev Owned by: Joel Sherrill
Priority: lowest Milestone: 2
Component: network/legacy Version: unknown
Severity: normal Keywords:
Cc: bugs@… Blocked By:
Blocking:

Description

This patch includes two fixes:

  1. ppp_tty.c/pppstart():

Type of the ioffset variable must be u_long,
otherwise in the case of the big output packet
endless loop may occur.

  1. Local variables must not be used in a device.write

routines (if_ppp.c/ppp_txdaemon() and ppp_tty.c/pppstart() )
Now ppp_softc structure have own character for writing to device (sc_outchar).
I think that converting local variables to static is not a right solution, because problems will occur in the case of
two or more ppp instances.

This patch must be applyed to the latest libnetworking/net/*ppp* files. Please ensure that.

Release:
only CVS

Environment:
lfs 3.0 (from linuxfromscratch.org)

Attachments (1)

p​ (4.9 KB) - added by Ilya Alexeev on 12/03/06 at 13:31:13.
p

Download all attachments as: .zip

Change History (3)

comment:1 Changed on 03/27/02 at 13:36:33 by Joel Sherrill

Status: assigned → closed

State-Changed-From-To: analyzed->closed
State-Changed-Why: Patch applied and version changed.

Changed on 12/03/06 at 13:31:13 by Ilya Alexeev

Attachment: p​ added

p

comment:2 Changed on 10/10/17 at 06:37:47 by Sebastian Huber

Component: patch - do not use → network/legacy
Note: See TracTickets for help on using tickets.