Opened on 07/07/10 at 13:35:12

Closed on 11/22/12 at 14:39:54

#1607 closed defect (fixed)

__RTEMS_SIZEOF_VOID_P__ flawed design

Reported by: Ralf Corsepius Owned by: Joel Sherrill
Priority: highest Milestone: 4.11
Component: score Version: 4.11
Severity: blocker Keywords:
Cc: chrisj@…, sebastian.huber@…, gedare@… Blocked By:
Blocking:

Description

This change is a massive design flaw:

2010-06-29 Joel Sherrill <joel.sherrill@…>

  • configure.ac, score/include/rtems/score/percpu.h: Add

RTEMS_SIZEOF_VOID_P to cpuopts.h so percpu.h has this information
available during build and after installation.

Sizes are compile time constants and therefore may depend upon compiler
flags (e.g. multilibs) flags. Defining them in a globally exported
header being shared by different architecture variants qualifies is absurd.

Proposal: Joel to revert his whole RTEMS_SIZEOF_VOID_P patch-set.

Attachments (3)

off.c​ (263 bytes) - added by Joel Sherrill on 07/16/10 at 13:48:52.
Test Program for Structure offsets in inline asm
test.c​ (337 bytes) - added by Gedare Bloom on 07/16/10 at 14:39:48.
Test Program for Structure offsets in inline asm
rtems-cvs.diff​ (67.1 KB) - added by Gedare Bloom on 07/19/10 at 17:21:10.
Patch: proposed fix alternative to using installed headers

Download all attachments as: .zip

Change History (11)

comment:1 Changed on 07/07/10 at 13:35:29 by Ralf Corsepius

Priority: normal → highest

comment:2 Changed on 07/07/10 at 13:45:16 by Sebastian Huber

Cc: Sebastian Huber added

comment:3 Changed on 07/07/10 at 16:16:10 by Gedare Bloom

Cc: giddyup44@… added

Changed on 07/16/10 at 13:48:52 by Joel Sherrill

Attachment: off.c​ added

Test Program for Structure offsets in inline asm

Changed on 07/16/10 at 14:39:48 by Gedare Bloom

Attachment: test.c​ added

Test Program for Structure offsets in inline asm

comment:4 Changed on 07/16/10 at 14:39:48 by Gedare Bloom

attachments.isobsolete: 0 → 1

Changed on 07/19/10 at 17:21:10 by Gedare Bloom

Attachment: rtems-cvs.diff​ added

Patch: proposed fix alternative to using installed headers

comment:5 Changed on 07/20/10 at 01:32:31 by Chris Johns

Cc: Chris Johns added

comment:6 Changed on 01/21/11 at 15:26:45 by Sebastian Huber

blocked: → 1729

comment:7 Changed on 11/22/12 at 14:39:54 by Sebastian Huber

Resolution: → fixed
Status: new → closed

​http://git.rtems.org/rtems/commit/?id=f1738ed619ed01199535410887a81c6ac99e482c

comment:8 Changed on 11/24/14 at 18:58:28 by Gedare Bloom

Version: HEAD → 4.11

Replace Version=HEAD with Version=4.11 for the tickets with Milestone >= 4.11

Note: See TracTickets for help on using tickets.