#1607 closed defect (fixed)

__RTEMS_SIZEOF_VOID_P__ flawed design

Reported by: Ralf Corsepius Owned by: Joel Sherrill
Priority: highest Milestone: 4.11
Component: score Version: 4.11
Severity: blocker Keywords:
Cc: chrisj@…, sebastian.huber@…, gedare@… Blocked By:
Blocking:

Description

This change is a massive design flaw:

2010-06-29 Joel Sherrill <joel.sherrill@…>

  • configure.ac, score/include/rtems/score/percpu.h: Add

RTEMS_SIZEOF_VOID_P to cpuopts.h so percpu.h has this information
available during build and after installation.

Sizes are compile time constants and therefore may depend upon compiler
flags (e.g. multilibs) flags. Defining them in a globally exported
header being shared by different architecture variants qualifies is absurd.

Proposal: Joel to revert his whole RTEMS_SIZEOF_VOID_P patch-set.

Attachments (3)

off.c (263 bytes) - added by Joel Sherrill on Jul 16, 2010 at 1:48:52 PM.
Test Program for Structure offsets in inline asm
test.c (337 bytes) - added by Gedare Bloom on Jul 16, 2010 at 2:39:48 PM.
Test Program for Structure offsets in inline asm
rtems-cvs.diff (67.1 KB) - added by Gedare Bloom on Jul 19, 2010 at 5:21:10 PM.
Patch: proposed fix alternative to using installed headers

Download all attachments as: .zip

Change History (11)

comment:1 Changed on Jul 7, 2010 at 1:35:29 PM by Ralf Corsepius

Priority: normalhighest

comment:2 Changed on Jul 7, 2010 at 1:45:16 PM by Sebastian Huber

Cc: Sebastian Huber added

comment:3 Changed on Jul 7, 2010 at 4:16:10 PM by Gedare Bloom

Cc: giddyup44@… added

Changed on Jul 16, 2010 at 1:48:52 PM by Joel Sherrill

Attachment: off.c added

Test Program for Structure offsets in inline asm

Changed on Jul 16, 2010 at 2:39:48 PM by Gedare Bloom

Attachment: test.c added

Test Program for Structure offsets in inline asm

comment:4 Changed on Jul 16, 2010 at 2:39:48 PM by Gedare Bloom

attachments.isobsolete: 01

Changed on Jul 19, 2010 at 5:21:10 PM by Gedare Bloom

Attachment: rtems-cvs.diff added

Patch: proposed fix alternative to using installed headers

comment:5 Changed on Jul 20, 2010 at 1:32:31 AM by Chris Johns

Cc: Chris Johns added

comment:6 Changed on Jan 21, 2011 at 3:26:45 PM by Sebastian Huber

blocked: 1729

comment:8 Changed on Nov 24, 2014 at 6:58:28 PM by Gedare Bloom

Version: HEAD4.11

Replace Version=HEAD with Version=4.11 for the tickets with Milestone >= 4.11

Note: See TracTickets for help on using tickets.