Opened on 06/14/10 at 13:13:26
Closed on 06/17/10 at 03:38:57
#1556 closed defect (fixed)
rfs type defs violate type naming conventions
Reported by: | Ralf Corsepius | Owned by: | Chris Johns |
---|---|---|---|
Priority: | normal | Milestone: | 4.10 |
Component: | score | Version: | 4.10 |
Severity: | blocker | Keywords: | |
Cc: | joel.sherrill@…, chrisj@… | Blocked By: | |
Blocking: |
Description
The rfs code applies this kind of typedefs
typedef struct xxxx_t {
...
} xxxx;
This violates the conventions POSIX and RTEMS apply on types' naming:
*_t is meant to be a typedef.
i.e. these typedefs are *all* reversed and should be renamed such that the *_t are the typedefs.
Proposal: drop the structs and use typedefs only, i.e.
typedef struct {
...
} xxx_t;
Alternatively
typedef struct xxxx_s {
...
} xxx_t;
I haven't checked it this also affects rtems-4.10, but marking this as a blocker bug for 4.10 until this has been verified.
Change History (6)
comment:1 Changed on 06/14/10 at 13:13:37 by Ralf Corsepius
Milestone: | 4.11 → 4.10 |
---|
comment:2 Changed on 06/14/10 at 13:14:46 by Ralf Corsepius
Summary: | rfs type efs violate type naming conventions → rfs type defs violate type naming conventions |
---|
comment:3 Changed on 06/14/10 at 14:35:29 by Joel Sherrill
Owner: | changed from Joel Sherrill to Chris Johns |
---|
comment:4 Changed on 06/14/10 at 23:43:36 by Joel Sherrill
Cc: | Joel Sherrill added |
---|
comment:5 Changed on 06/14/10 at 23:47:20 by Chris Johns
Status: | new → assigned |
---|
comment:6 Changed on 06/17/10 at 03:38:57 by Chris Johns
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Committed changes to HEAD and 4.10.