#1556 closed defect (fixed)

rfs type defs violate type naming conventions

Reported by: Ralf Corsepius Owned by: Chris Johns
Priority: normal Milestone: 4.10
Component: score Version: 4.10
Severity: blocker Keywords:
Cc: joel.sherrill@…, chrisj@… Blocked By:
Blocking:

Description

The rfs code applies this kind of typedefs

typedef struct xxxx_t {
...
} xxxx;

This violates the conventions POSIX and RTEMS apply on types' naming:

*_t is meant to be a typedef.

i.e. these typedefs are *all* reversed and should be renamed such that the *_t are the typedefs.

Proposal: drop the structs and use typedefs only, i.e.
typedef struct {
...
} xxx_t;

Alternatively
typedef struct xxxx_s {
...
} xxx_t;

I haven't checked it this also affects rtems-4.10, but marking this as a blocker bug for 4.10 until this has been verified.

Change History (6)

comment:1 Changed on Jun 14, 2010 at 1:13:37 PM by Ralf Corsepius

Milestone: 4.114.10

comment:2 Changed on Jun 14, 2010 at 1:14:46 PM by Ralf Corsepius

Summary: rfs type efs violate type naming conventionsrfs type defs violate type naming conventions

comment:3 Changed on Jun 14, 2010 at 2:35:29 PM by Joel Sherrill

Owner: changed from Joel Sherrill to Chris Johns

comment:4 Changed on Jun 14, 2010 at 11:43:36 PM by Joel Sherrill

Cc: Joel Sherrill added

comment:5 Changed on Jun 14, 2010 at 11:47:20 PM by Chris Johns

Status: newassigned

comment:6 Changed on Jun 17, 2010 at 3:38:57 AM by Chris Johns

Resolution: fixed
Status: assignedclosed

Committed changes to HEAD and 4.10.

Note: See TracTickets for help on using tickets.