Notice: We have migrated to GitLab launching 2024-05-01 see here:

#1518 assigned defect

Bdbuf IO request cleanup

Reported by: Sebastian Huber Owned by: Chris Johns
Priority: low Milestone: Indefinite
Component: lib/block Version:
Severity: minor Keywords:
Cc: gedare@… Blocked By:

Description (last modified by Sebastian Huber)

Reported by Chris Johns in Bug 1433:

We need to remove the SG alloc calls from the cache read code. The code
currently allocates a block of RAM on the stack with an array of pointers to
the BD. I consider the array of size of 1 at the end of the struct and the way
it is allocated as fragile code. The BD already contain a link node which is
not used at the driver layer. It would be much better to use a chain to hold a
list of BDs to fill.

Change History (9)

comment:1 Changed on 08/06/10 at 21:35:15 by Joel Sherrill

Milestone: 4.104.11

comment:2 Changed on 12/03/13 at 14:05:22 by Gedare Bloom

Cc: Gedare Bloom added

comment:3 Changed on 12/03/13 at 14:15:53 by Sebastian Huber

Yes, this is still relevant.

comment:4 Changed on 11/23/14 at 00:20:44 by Joel Sherrill

Description: modified (diff)
Owner: changed from Joel Sherrill to Chris Johns
Status: newassigned

This is Chris' area of the code.

comment:5 Changed on 12/17/14 at 07:26:39 by Sebastian Huber

Description: modified (diff)
Milestone: 4.115.0
Priority: normallow
Severity: normalminor

comment:6 Changed on 08/14/17 at 00:49:46 by Chris Johns

Milestone: 5.0Indefinite
Version: 4.10

comment:7 Changed on 10/10/17 at 06:49:19 by Sebastian Huber

Component: scorelib/block

comment:8 Changed on 12/15/22 at 16:43:21 by Joel Sherrill

Owner: changed from Joel Sherrill to Chris Johns
Status: newassigned

Is this still valid?

comment:9 Changed on 12/16/22 at 05:51:48 by Sebastian Huber

Yes, it is still valid.

Note: See TracTickets for help on using tickets.