#1459 assigned defect

Add rtems_shell_main_monitor to cpukit/libmisc/shell/shell.h?

Reported by: Ralf Corsepius Owned by: Chris Johns
Priority: normal Milestone: 6.1
Component: shell Version: 4.10
Severity: minor Keywords:
Cc: chrisj@…, vattam.santosh@… Blocked By:
Blocking:

Description (last modified by Joel Sherrill)

rtems_shell_main_monitor
is a private function of
cpukit/libmisc/shell/cmds.c

However, the way
testsuites/libtests/monitor02/init.c
uses it (as a public/exported function) to me reads as a strong indication that
rtems_shell_main_monitor()
should be "made public" by declaring/prototyping it in
cpukit/libmisc/shell/shell.h

Change History (5)

comment:1 Changed on Dec 24, 2009 at 10:07:08 PM by Santosh Vattam

Cc: Santosh Vattam added

comment:2 Changed on Dec 25, 2009 at 2:29:03 PM by Joel Sherrill

Owner: changed from Joel Sherrill to Chris Johns

comment:3 Changed on May 15, 2010 at 6:42:03 AM by Chris Johns

Milestone: 4.104.11
Status: newassigned

Exporting this interface from the shell is a hack as well. The central issue is the purpose of the monitor now we have a shell. Should we consume the monitor into the shell and remove the duplicate code in RTEMS ? The monitor has stdin handling, terminal handling plus help formatting (which is much better than the shell's). I think these can all be merged into the shell and the monitor goes away.

I think this should be moved to the 4.11 milestone, which I have done, and we live with the current code for 4.10.

Once issue this raises is the pressure on the shell with all the files that are starting to appear in it. Maybe the monitor command remain in its directory.

comment:4 Changed on Nov 23, 2014 at 5:37:06 PM by Joel Sherrill

Description: modified (diff)
Milestone: 4.115.0
Summary: Add rtems_shell_main_monitor to cpukit/libmisc/shell/shell.h?Make Monitor Commands first class citizens in shell,

The monitor predates the shell. There is really no point in having two CLIs. The monitor commands are available in the shell but the integration is a hack. The monitor commands need to be made first class shell commands and the set for looking at objects enhanced to include more objects.

This may be a decent GSoC project.

comment:5 Changed on Nov 9, 2017 at 6:26:42 AM by Sebastian Huber

Milestone: 5.06.1

Milestone renamed

Note: See TracTickets for help on using tickets.