Notice: We have migrated to GitLab launching 2024-05-01 see here: https://gitlab.rtems.org/

#1445 closed defect

sparc+pc386 pci_[read|write]_config_* messed up

Reported by: Ralf Corsepius Owned by: Joel Sherrill
Priority: normal Milestone: 4.10
Component: bsps Version: 4.10
Severity: critical Keywords:
Cc: Blocked By:
Blocking:

Description (last modified by Gedare Bloom)

This change to c/src/lib/libbsp/sparc/shared/include/pci.h:

2009-09-25 Joel Sherrill <joel.sherrill@…>

  • shared/include/pci.h: Change extern inline to static inline.

reveils a conflict between the pci_[read|write]_config_* implementations in
c/src/lib/libbsp/sparc/shared/include/pci.h
and
c/src/lib/libbsp/sparc/leon2/pci/pci.c
c/src/lib/libbsp/sparc/leon3/pci/pci.c
and breaks building the leon* BSP.

AFAIS, one of the pci_[read|write]_config_* implementations' function names
need to be changed (likely those in leon*/pci/*.c

Change History (3)

comment:1 Changed on 09/30/09 at 11:34:01 by Ralf Corsepius

Severity: normalcritical
Summary: sparc pci_[read|write]_config_* messed upsparc+pc386 pci_[read|write]_config_* messed up

comment:2 Changed on 09/30/09 at 13:33:48 by Ralf Corsepius

FYI: I am going to rename the
pci_[read|write]_config*()
functions inside of affected
<bsp>/pci/pci.c's

into
BSP_[read|write]_config*()

This resolves the function name clash, but has the side-effect of all calls to pci_[read|write]_config*()
to refer to the implementations in cpukit/include/rtems/pci.h, i.e. to call their BSP_pci_[read|write]_config*()

... even when being call from inside of the BSP ;)

I don't know if this behavior is desired.

comment:3 Changed on 11/22/14 at 13:45:39 by Gedare Bloom

Description: modified (diff)
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.