#1431 closed defect (fixed)

Timer server is broken

Reported by: Sebastian Huber Owned by: Joel Sherrill
Priority: normal Milestone: 4.10
Component: score Version: 4.10
Severity: major Keywords:
Cc: Blocked By:
Blocking:

Description

The rework for code coverage analysis introduced a bug in 'cpukit/score/src/watchdogadjusttochain.c'. Due to a missing loop break condition an item of an empty list will be fetched. This leads to arbitrary writes to memory.

Is it desirable to change constructs like

if (A && B) {

...

}

to

if (A) {

if (B) {

...

}

}

or

while (A) {

...

}

to

while (1) {

if (!A) {

break;

}
...

}

?

Attachments (1)

ts.patch (2.4 KB) - added by Sebastian Huber on Jul 17, 2009 at 11:39:09 AM.
Fix proposal

Download all attachments as: .zip

Change History (2)

Changed on Jul 17, 2009 at 11:39:09 AM by Sebastian Huber

Attachment: ts.patch added

Fix proposal

comment:1 Changed on Jul 17, 2009 at 1:33:57 PM by Joel Sherrill

Resolution: fixed
Status: newclosed

Patch committed. Ran coverage to verify that it didn't introduce a new uncovered range of code.

Sorry to have broken it. Trying to get to 100% test coverage and eliminate dead code.

Note: See TracTickets for help on using tickets.