#1423 closed defect (fixed)

inconsitience in _Objects_Initialize_information — at Version 5

Reported by: Nickolay Semyonov-Kolchin Owned by: Joel Sherrill
Priority: normal Milestone: 4.11
Component: score Version: 4.10
Severity: minor Keywords:
Cc: Gedare Bloom Blocked By:
Blocking:

Description (last modified by Joel Sherrill)

Our partners found precision lost in _Objects_Initialize_information function.

It is declared as (objectinitializeinformation.c):

void _Objects_Initialize_information(

Objects_Information *information,
Objects_APIs the_api,
uint32_t the_class,
uint32_t maximum,
uint16_t size,
bool is_string,
uint32_t maximum_name_length

#if defined(RTEMS_MULTIPROCESSING)

,
bool supports_global,
Objects_Thread_queue_Extract_callout extract

#endif
)

And later in code:

information->the_class = the_class;

But information->the_class have type uint16_t.

From object.h:

/ This is the class of this object set. */
uint16_t the_class;

Proposed solution: the_class should have same type everywhere.

Change History (7)

comment:1 Changed on 12/24/09 at 22:12:10 by Santosh Vattam

Cc: Santosh Vattam added

Changed on 12/25/09 at 09:48:04 by Santosh Vattam

Attachment: objectdoth.patch added

Changed the the_class type in object.h to uint32_t

Changed on 08/03/10 at 13:39:25 by Joel Sherrill

Attachment: pr1423.diff added

Patch which changes the_class to uint16_t

comment:2 Changed on 08/03/10 at 13:39:25 by Joel Sherrill

attachments.isobsolete: 01

comment:3 Changed on 08/06/10 at 21:36:15 by Joel Sherrill

Milestone: 4.104.11

comment:4 Changed on 04/11/14 at 19:34:24 by Gedare Bloom

Cc: Gedare Bloom added

Joel, Update patch and I think it is OK to commit and close..

comment:5 Changed on 11/23/14 at 14:43:23 by Joel Sherrill

Description: modified (diff)
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.