Opened on 12/13/06 at 06:51:33

Closed on 12/13/06 at 13:40:13

#1189 closed defect (fixed)

[patch] Character with the code > 127, blinks when printed on pc386 VGA console.

Reported by: Alexey Shamrin Owned by: Joel Sherrill
Priority: normal Milestone: 4.8
Component: bsps Version: unknown
Severity: normal Keywords:
Cc: Blocked By:
Blocking:

Description

When I try to print character with the code > 127 (extended ASCII) to pc386 VGA
console, I get the requested character, but it blinks!

The reason: char == signed char, so such characters get represented by
negative numbers. The sign bit then goes to attribute byte, giving
blinking.

The patch can be applied to rtems/c/src/lib/libbsp/i386/pc386/console/outch.c

--- outch.c Thu Nov 30 09:56:24 2006
+++ outch_fixed.c Thu Nov 30 09:57:32 2006
@@ -141,7 +141,7 @@

return;

}
default: {

  • *pt_bitmap = car | attribute;

+ *pt_bitmap = (unsigned char)car | attribute;

advanceCursor();

return;

}

Change History (1)

comment:1 Changed on 12/13/06 at 13:40:13 by Joel Sherrill

Resolution: → fixed
Status: new → closed

Patch committed to both 4.7 branch and CVS head.

Note: See TracTickets for help on using tickets.