Ignore:
Timestamp:
Sep 12, 2007, 3:15:32 PM (14 years ago)
Author:
Joel Sherrill <joel.sherrill@…>
Branches:
4.10, 4.11, 4.8, 4.9, 5, master
Children:
bd51a63
Parents:
38feb6d5
Message:

2007-09-12 Joel Sherrill <joel.sherrill@…>

PR 1257/bsps

  • csb336/network/lan91c11x.c, csb337/startup/bspstart.c, edb7312/irq/irq.c, gba/irq/irq.c, gba/irq/irq_init.c, gp32/startup/bspstart.c, rtl22xx/startup/bspstart.c, shared/abort/abort.c, shared/abort/simple_abort.c, shared/irq/irq_init.c: Code outside of cpukit should use the public API for rtems_interrupt_disable/rtems_interrupt_enable. By bypassing the public API and directly accessing _CPU_ISR_Disable and _CPU_ISR_Enable, they were bypassing the compiler memory barrier directive which could lead to problems. This patch also changes the type of the variable passed into these routines and addresses minor style issues.
Location:
c/src/lib/libbsp/arm/shared/abort
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • c/src/lib/libbsp/arm/shared/abort/abort.c

    r38feb6d5 rf3343c6e  
    105105{
    106106    /* Clarify, which type is correct, CPU_Exception_frame or Context_Control */
    107 
    108     uint8_t    decode;
    109     uint8_t    insn_type;
    110 
    111     uint32_t    tmp;
     107    uint8_t               decode;
     108    uint8_t               insn_type;
     109    rtems_interrupt_level level;
    112110
    113111    g_data_abort_insn_list[g_data_abort_cnt & 0x3ff] = ctx->register_lr - 8;
     
    153151
    154152    /* disable interrupts, wait forever */
    155     _CPU_ISR_Disable(tmp);
     153    rtems_interrupt_disable(level);
    156154    while(1) {
    157155        continue;
  • c/src/lib/libbsp/arm/shared/abort/simple_abort.c

    r38feb6d5 rf3343c6e  
    110110  /* Clarify, which type is correct, CPU_Exception_frame or Context_Control */
    111111
    112   uint8_t    decode;
    113   uint8_t    insn_type;
    114   uint32_t    tmp;
     112  uint8_t               decode;
     113  uint8_t               insn_type;
     114  rtems_interrupt_level level;
    115115
    116116  decode = ((insn >> 20) & 0xff);
     
    153153
    154154  /* disable interrupts, wait forever */
    155   _CPU_ISR_Disable(tmp);
     155  rtems_interrupt_disable(level);
    156156  while(1) {
    157157    continue;
Note: See TracChangeset for help on using the changeset viewer.