Changeset f18e6d8 in rtems-tools


Ignore:
Timestamp:
May 5, 2021, 2:04:49 PM (3 months ago)
Author:
Alex White <alex.white@…>
Branches:
master
Children:
a918844
Parents:
eecde47
git-author:
Alex White <alex.white@…> (05/05/21 14:04:49)
git-committer:
Joel Sherrill <joel@…> (05/10/21 15:39:39)
Message:

rtemstoolkit/mailer.py: Fix option ordering for add_arguments

The ordering of keys cannot be guaranteed in a dictionary. This changes
the options iteration to no longer rely on key ordering.

Closes #4402

File:
1 edited

Legend:

Unmodified
Added
Removed
  • rtemstoolkit/mailer.py

    reecde47 rf18e6d8  
    22# RTEMS Tools Project (http://www.rtems.org/)
    33# Copyright 2013-2016 Chris Johns (chrisj@rtems.org)
     4# Copyright (C) 2021 On-Line Applications Research Corporation (OAR)
    45# All rights reserved.
    56#
     
    6263    argsp.add_argument('--mail', help = _options['--mail'], action = 'store_true')
    6364    argsp.add_argument('--use-gitconfig', help = _options['--use-gitconfig'], action = 'store_true')
    64     for o in list(_options)[1:]:
     65    no_add = ['--mail', '--use-gitconfig']
     66    for o in [opt for opt in list(_options) if opt not in no_add]:
    6567        argsp.add_argument(o, help = _options[o], type = str)
    6668
Note: See TracChangeset for help on using the changeset viewer.