Changeset f164ae75 in rtems

Timestamp:

05/30/12 11:41:31 (11 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

4.11, 5, master

Children:

53f2ca3, e308b3a7

Parents:

73c09b3b

git-author:

Sebastian Huber <sebastian.huber@…> (05/30/12 11:41:31)

git-committer:

Sebastian Huber <sebastian.huber@…> (05/31/12 09:05:48)

Message:

libblock: Move rtems_bdbuf_get_media_block() call

Move rtems_bdbuf_get_media_block() call inside the bdbuf lock.

File:

• cpukit/libblock/src/bdbuf.c (modified) (4 diffs)

cpukit/libblock/src/bdbuf.c

@@ -1781 +1781 @@
   rtems_status_code   sc = RTEMS_SUCCESSFUL;
   rtems_bdbuf_buffer *bd = NULL;
-  rtems_blkdev_bnum   media_block = 0;
+  rtems_blkdev_bnum   media_block;
+
+  rtems_bdbuf_lock_cache ();
 
   sc = rtems_bdbuf_get_media_block (dd, block, &media_block);
-  if (sc != RTEMS_SUCCESSFUL)
-    return sc;
-
-  rtems_bdbuf_lock_cache ();
-
-  /*
-   * Print the block index relative to the physical disk.
-   */
-  if (rtems_bdbuf_tracer)
-    printf ("bdbuf:get: %" PRIu32 " (%" PRIu32 ") (dev = %08x)\n",
-            media_block, block, (unsigned) dd->dev);
-
-  bd = rtems_bdbuf_get_buffer_for_access (dd, media_block);
-
-  switch (bd->state)
-  {
-    case RTEMS_BDBUF_STATE_CACHED:
-      rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_CACHED);
-      break;
-    case RTEMS_BDBUF_STATE_EMPTY:
-      rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_EMPTY);
-      break;
-    case RTEMS_BDBUF_STATE_MODIFIED:
-      /*
-       * To get a modified buffer could be considered a bug in the caller
-       * because you should not be getting an already modified buffer but user
-       * may have modified a byte in a block then decided to seek the start and
-       * write the whole block and the file system will have no record of this
-       * so just gets the block to fill.
-       */
-      rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_MODIFIED);
-      break;
-    default:
-      rtems_bdbuf_fatal (bd->state, RTEMS_BLKDEV_FATAL_BDBUF_STATE_2);
-      break;
-  }
-
-  if (rtems_bdbuf_tracer)
-  {
-    rtems_bdbuf_show_users ("get", bd);
-    rtems_bdbuf_show_usage ();
+  if (sc == RTEMS_SUCCESSFUL)
+  {
+    /*
+     * Print the block index relative to the physical disk.
+     */
+    if (rtems_bdbuf_tracer)
+      printf ("bdbuf:get: %" PRIu32 " (%" PRIu32 ") (dev = %08x)\n",
+              media_block, block, (unsigned) dd->dev);
+
+    bd = rtems_bdbuf_get_buffer_for_access (dd, media_block);
+
+    switch (bd->state)
+    {
+      case RTEMS_BDBUF_STATE_CACHED:
+        rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_CACHED);
+        break;
+      case RTEMS_BDBUF_STATE_EMPTY:
+        rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_EMPTY);
+        break;
+      case RTEMS_BDBUF_STATE_MODIFIED:
+        /*
+         * To get a modified buffer could be considered a bug in the caller
+         * because you should not be getting an already modified buffer but
+         * user may have modified a byte in a block then decided to seek the
+         * start and write the whole block and the file system will have no
+         * record of this so just gets the block to fill.
+         */
+        rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_MODIFIED);
+        break;
+      default:
+        rtems_bdbuf_fatal (bd->state, RTEMS_BLKDEV_FATAL_BDBUF_STATE_2);
+        break;
+    }
+
+    if (rtems_bdbuf_tracer)
+    {
+      rtems_bdbuf_show_users ("get", bd);
+      rtems_bdbuf_show_usage ();
+    }
   }
 
@@ -1831 +1831 @@
   *bd_ptr = bd;
 
-  return RTEMS_SUCCESSFUL;
+  return sc;
 }
 
@@ -1998 +1998 @@
   rtems_blkdev_request *req = NULL;
   rtems_bdbuf_buffer   *bd = NULL;
-  rtems_blkdev_bnum     media_block = 0;
-
-  sc = rtems_bdbuf_get_media_block (dd, block, &media_block);
-  if (sc != RTEMS_SUCCESSFUL)
-    return sc;
+  rtems_blkdev_bnum     media_block;
 
   /*
@@ -2013 +2009 @@
                       (bdbuf_config.max_read_ahead_blocks + 1));
 
-  if (rtems_bdbuf_tracer)
-    printf ("bdbuf:read: %" PRIu32 " (%" PRIu32 ") (dev = %08x)\n",
-            media_block + dd->start, block, (unsigned) dd->dev);
-
   rtems_bdbuf_lock_cache ();
-  rtems_bdbuf_create_read_request (dd, media_block, req, &bd);
-
-  if (req->bufnum > 0)
-  {
-    sc = rtems_bdbuf_execute_transfer_request (dd, req, true);
+
+  sc = rtems_bdbuf_get_media_block (dd, block, &media_block);
+  if (sc == RTEMS_SUCCESSFUL)
+  {
+    if (rtems_bdbuf_tracer)
+      printf ("bdbuf:read: %" PRIu32 " (%" PRIu32 ") (dev = %08x)\n",
+              media_block + dd->start, block, (unsigned) dd->dev);
+
+    rtems_bdbuf_create_read_request (dd, media_block, req, &bd);
+
+    if (req->bufnum > 0)
+    {
+      sc = rtems_bdbuf_execute_transfer_request (dd, req, true);
+      if (sc == RTEMS_SUCCESSFUL)
+      {
+        rtems_chain_extract_unprotected (&bd->link);
+        rtems_bdbuf_group_obtain (bd);
+      }
+    }
+
     if (sc == RTEMS_SUCCESSFUL)
     {
-      rtems_chain_extract_unprotected (&bd->link);
-      rtems_bdbuf_group_obtain (bd);
-    }
-  }
-
-  if (sc == RTEMS_SUCCESSFUL)
-  {
-    switch (bd->state)
-    {
-      case RTEMS_BDBUF_STATE_CACHED:
-        rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_CACHED);
-        break;
-      case RTEMS_BDBUF_STATE_MODIFIED:
-        rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_MODIFIED);
-        break;
-      default:
-        rtems_bdbuf_fatal (bd->state, RTEMS_BLKDEV_FATAL_BDBUF_STATE_4);
-        break;
-    }
-
-    if (rtems_bdbuf_tracer)
-    {
-      rtems_bdbuf_show_users ("read", bd);
-      rtems_bdbuf_show_usage ();
-    }
-
-    *bd_ptr = bd;
-  }
-  else
-    *bd_ptr = NULL;
+      switch (bd->state)
+      {
+        case RTEMS_BDBUF_STATE_CACHED:
+          rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_CACHED);
+          break;
+        case RTEMS_BDBUF_STATE_MODIFIED:
+          rtems_bdbuf_set_state (bd, RTEMS_BDBUF_STATE_ACCESS_MODIFIED);
+          break;
+        default:
+          rtems_bdbuf_fatal (bd->state, RTEMS_BLKDEV_FATAL_BDBUF_STATE_4);
+          break;
+      }
+
+      if (rtems_bdbuf_tracer)
+      {
+        rtems_bdbuf_show_users ("read", bd);
+        rtems_bdbuf_show_usage ();
+      }
+    }
+    else
+    {
+      bd = NULL;
+    }
+  }
 
   rtems_bdbuf_unlock_cache ();
+
+  *bd_ptr = bd;
 
   return sc;