Changeset e315b460 in rtems


Ignore:
Timestamp:
08/01/14 19:13:40 (8 years ago)
Author:
Al Viro <viro@…>
Branches:
5, master
Children:
2c5980f
Parents:
9da567b2
git-author:
Al Viro <viro@…> (08/01/14 19:13:40)
git-committer:
Sebastian Huber <sebastian.huber@…> (07/16/18 05:22:12)
Message:

kill wbuf_queued/wbuf_dwork_lock

schedule_delayed_work() happening when the work is already pending is
a cheap no-op. Don't bother with ->wbuf_queued logics - it's both
broken (cancelling ->wbuf_dwork leaves it set, as spotted by Jeff Harris)
and pointless. It's cheaper to let schedule_delayed_work() handle that
case.

Reported-by: Jeff Harris <jefftharris@…>
Tested-by: Jeff Harris <jefftharris@…>
Cc: stable@…
Signed-off-by: Al Viro <viro@…>

File:
1 edited

Legend:

Unmodified
Added
Removed
  • cpukit/libfs/src/jffs2/src/jffs2_fs_sb.h

    r9da567b2 re315b460  
    135135
    136136        struct delayed_work wbuf_dwork; /* write-buffer write-out work */
    137         int wbuf_queued;                /* non-zero delayed work is queued */
    138         spinlock_t wbuf_dwork_lock;     /* protects wbuf_dwork and and wbuf_queued */
    139137
    140138        unsigned char *oobbuf;
Note: See TracChangeset for help on using the changeset viewer.