Changeset e106aa73 in rtems


Ignore:
Timestamp:
11/19/14 20:44:54 (9 years ago)
Author:
Josh Oguin <josh.oguin@…>
Branches:
4.11, 5, master
Children:
fbafb8f2
Parents:
90a8e42b
git-author:
Josh Oguin <josh.oguin@…> (11/19/14 20:44:54)
git-committer:
Joel Sherrill <joel.sherrill@…> (11/26/14 13:51:59)
Message:

cpukit/posix/src/timertsr.c: Add _Assert()

CodeSonar? flagged this as an empty if body. Upon analysis, it turned
out to be an error that we think should never occur but if it did,
there is nothing we could do about it. It would likely just indicate
the thread was deleted before we got here. Adding the _Assert() at least
will flag this if it ever occurs during a debug build and we can discuss
what happened.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • cpukit/posix/src/timertsr.c

    r90a8e42b re106aa73  
    7474
    7575  if ( pthread_kill ( ptimer->thread_id, ptimer->inf.sigev_signo ) ) {
    76     /* XXX error handling */
     76    _Assert( FALSE );
     77    /*
     78     * TODO: What if an error happens at run-time? This should never
     79     *       occur because the timer should be canceled if the thread
     80     *       is deleted. This method is being invoked from the Clock
     81     *       Tick ISR so even if we decide to take action on an error,
     82     *       we don't have many options. We shouldn't shut the system down.
     83     */
    7784  }
    7885
Note: See TracChangeset for help on using the changeset viewer.