Changeset de9edc4 in rtems

Timestamp:

Aug 31, 1998, 10:56:20 PM (21 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.10, 4.11, 4.8, 4.9, master

Children:

b285860

Parents:

85734b3

Message:

Patch from Eric Valette <valette@…>:

Here is a brief description of the attached patch :

1) There was a bug in the code for the COM2 serial line driver. Aleksey
gave me a fix that fixes the driver code itself. I would like to thank
him again publicly,

2) I introduced constants in the serial driver code because I had a hard
time reading the meanning of hexadecimal values in the NS data book :)

3)You can now mix printk and printf on serial line (tested on COM2).
There is a #ifdef PRINTK_ON_SERIAL in console.c that enables to have
printk on console while printf on serial line,
4) Removed call to displayCpuInfo because anyway if was at the wrong
place for serial line console (too early). It can anyway be called at
application level,

5) The original printk was unable to display negative integer values
and was also recursive. It now works corectly,

All the modifications have been tested here on the COM2 port from
a PC running RTEMS to a PC running linux,

NB : there is still a bug on PC386 serial line : exit does not flush the
remaining output queue. As this is not a bug in the driver itself but
somewhere in PC386 initialization/termios relationship it will be part
of another patch.

NB2 : As Emmanuel excerced the exception hanlder code, while porting the
SMC driver to the new BSD stack, we found a bug in the exception
handler : it shall not delete the current thread in case we are running
at interrupt level. This will be part of another patch...

Location:

c/src/lib/libbsp/i386

Files:

• pc386/console/console.c (modified) (4 diffs)
• shared/io/printk.c (modified) (7 diffs)

c/src/lib/libbsp/i386/pc386/console/console.c

@@ -43 +43 @@
 #include <libcpu/cpuModel.h>
 
-int PC386ConsolePort = PC386_CONSOLE_PORT_CONSOLE;
+/*
+ * Possible value for console input/output :
+ *      PC386_CONSOLE_PORT_CONSOLE
+ *      PC386_UART_COM1
+ *      PC386_UART_COM2
+ */
+
+int PC386ConsolePort = PC386_UART_COM2;
 
 static int conSetAttr(int minor, const struct termios *);
@@ -80 +87 @@
   static   char exit_msg[] = "EXECUTIVE SHUTDOWN! Any key to reboot...";
   unsigned char  ch;
-  const    unsigned char *cp;
-        
  
   /*
@@ -185 +190 @@
           printk("Initialized console on port COM2 9600-8-N-1\n\n");
         }
+#define  PRINTK_ON_SERIAL     
+#ifdef PRINTK_ON_SERIAL
+      /*
+       * You can remove the follwoing tree lines if you want to have printk
+       * using the video console for output while printf use serial line.
+       * This may be convenient to debug the serial line driver itself...
+       */
       printk("Warning : This will be the last message displayed on console\n");
       BSP_output_char = (BSP_output_char_function_type) BSP_output_char_via_serial;
       BSP_poll_char   = (BSP_polling_getchar_function_type) BSP_poll_char_via_serial;
-    }
-#define  DISPLAY_CPU_INFO 
-#ifdef DISPLAY_CPU_INFO
-  printCpuInfo();
-#endif
-  
+#endif  
+    }
   return RTEMS_SUCCESSFUL;
 } /* console_initialize */
@@ -447 +455 @@
 
 
-
-
-
-
-
-

c/src/lib/libbsp/i386/shared/io/printk.c

@@ -21 +21 @@
 
 #include <stdarg.h>
-
+#include <stdio.h>
 #include <bspIo.h>
+#include <libcpu/cpu.h>
 
 /*-------------------------------------------------------------------------+
@@ -32 +33 @@
 +--------------------------------------------------------------------------*/
 static void
-printNum(long int num, int base)
+printNum(long unsigned int num, int base, int sign)
 {
-  long int n;
+  long unsigned int n;
+  int count;
+  char toPrint[20];
 
-  if ((n = num / base) > 0)
-    printNum(n, base);
-  BSP_output_char("0123456789ABCDEF"[(int)(num % base)]);
+  if ( (sign == 1) && ((long)num <  0) ) {
+    BSP_output_char('-');
+    num = -num;
+  }
+  
+  count = 0;
+  while ((n = num / base) > 0) {
+    toPrint[count++] = (num - (n*base));
+    num = n ;
+  }
+  toPrint[count++] = num;
+
+  for (n = 0; n < count; n++){
+    BSP_output_char("0123456789ABCDEF"[(int)(toPrint[count-(n+1)])]);
+  }
 } /* printNum */
 
@@ -55 +70 @@
   va_list  ap;      /* points to each unnamed argument in turn */
   char     c, *str;
-  int      lflag, base;
+  int      lflag, base, sign;
+  unsigned int level;
+
+  _CPU_ISR_Disable(level);
  
   va_start(ap, fmt); /* make ap point to 1st unnamed arg */
@@ -62 +80 @@
     lflag = 0;
     base  = 0;
+    sign = 0;
     if (*fmt == '%')
     {
@@ -71 +90 @@
       switch (c)
       {
-        case 'o': case 'O': base = 8; break;
-        case 'd': case 'D': base = 10; break;
-        case 'x': case 'X': base = 16; break;
+        case 'o': case 'O': base = 8; sign = 0; break;
+        case 'd': case 'D': base = 10; sign = 1; break;
+        case 'u': case 'U': base = 10; sign = 0; break;
+        case 'x': case 'X': base = 16; sign = 0; break;
         case 's':
           for (str = va_arg(ap, char *); *str; str++) 
@@ -88 +108 @@
       if (base)
         printNum(lflag ? va_arg(ap, long int) : (long int)va_arg(ap, int),
-                 base);
+                 base, sign);
     }
     else
@@ -96 +116 @@
   }
   va_end(ap); /* clean up when done */
+  _CPU_ISR_Enable(level);
+
 } /* printk */