Changeset da9b538 in rtems

Timestamp:

Jun 23, 2010, 11:28:46 PM (9 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.11, master

Children:

d290bbb

Parents:

ef08dc1

Message:

2010-06-23 Joel Sherrill <joel.sherrilL@…>

• libmisc/stackchk/check.c: More clean up and coverage improvements..

Location:

cpukit

Files:

• ChangeLog (modified) (1 diff)
• libmisc/stackchk/check.c (modified) (6 diffs)

cpukit/ChangeLog

@@ +1 @@
+2010-06-23      Joel Sherrill <joel.sherrilL@OARcorp.com>
+
+        * libmisc/stackchk/check.c: More clean up and coverage improvements..
+
 2010-06-23      Joel Sherrill <joel.sherrilL@OARcorp.com>
 

cpukit/libmisc/stackchk/check.c

@@ -144 +144 @@
   };
 
-  if (Stack_check_Initialized)
     return;
 
@@ -165 +164 @@
                                   (char *) _CPU_Interrupt_stack_low;
       Stack_check_Dope_stack(&Stack_check_Interrupt_stack);
-  }
+   }
   #endif
 
@@ -213 +212 @@
  *        the following message out.
  */
+void Stack_check_report_blown_task(
+  Thread_Control *running,
+  bool pattern_ok
+) RTEMS_COMPILER_NO_RETURN_ATTRIBUTE;
+
 void Stack_check_report_blown_task(Thread_Control *running, bool pattern_ok)
 {
@@ -312 +316 @@
   }
 
+
+  /*
+   * Let's report as much as we can.
+   */
+  if ( !sp_ok || !pattern_ok ) {
+    Stack_check_report_blown_task( _Thread_Executing, pattern_ok );
+    /* DOES NOT RETURN */
+  }
+
   /*
    * The Stack Pointer and the Pattern Area are OK so return false.
    */
-  if ( sp_ok && pattern_ok )
-    return false;
-
-  /*
-   * Let's report as much as we can.
-   */
-  Stack_check_report_blown_task( _Thread_Executing, pattern_ok );
-  return true;
+  return false;
 }
 
@@ -328 +334 @@
  * Stack_check_find_high_water_mark
  */
-void *Stack_check_find_high_water_mark(
+static inline void *Stack_check_find_high_water_mark(
   const void *s,
   size_t      n
@@ -491 +497 @@
   print_context = NULL;
   print_handler = NULL;
-
 }