Changeset c257429f in rtems

Timestamp:

11/12/99 21:15:12 (24 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.10, 4.11, 4.8, 4.9, 5, master

Children:

0c5ab522

Parents:

2183b65

Message:

+ Moved error checks to before the dispatch disable where possible.
+ Modified correct return path to call _ITRON_return_errorno( E_OK ) instead

of enabling dispatching and returning E_OK.

Files:

• c/src/exec/itron/src/cre_tsk.c (modified) (3 diffs)
• cpukit/itron/src/cre_tsk.c (modified) (3 diffs)

c/src/exec/itron/src/cre_tsk.c

@@ -33 +33 @@
 
   /*
-   * Disable dispatching.
-   */
-  
-  _Thread_Disable_dispatch();
-
-  /*
    * Validate Parameters.
    */
   
  if ( pk_ctsk == NULL )
-    _ITRON_return_errorno( E_PAR );
+    return E_PAR;
 
   if ((pk_ctsk->tskatr != TA_ASM ) &&
@@ -55 +49 @@
       (pk_ctsk->tskatr != TA_COP6) &&
       (pk_ctsk->tskatr != TA_COP7))
-    _ITRON_return_errorno( E_RSATR );
+    return E_RSATR;
 
   if (( pk_ctsk->itskpri <= 0 ) || ( pk_ctsk->itskpri >= 256 ))
-    _ITRON_return_errorno( E_PAR );
+    return E_PAR;
   if ( pk_ctsk->task == NULL )
-    _ITRON_return_errorno( E_PAR );
+    return E_PAR;
   if ( pk_ctsk->stksz < 0 )
-    _ITRON_return_errorno( E_PAR );
+    return E_PAR;
   
+  /*
+   * Disable dispatching.
+   */
+  
+  _Thread_Disable_dispatch();
+
   /*
    * allocate the thread.
@@ -107 +107 @@
   the_thread->Start.entry_point = (Thread_Entry) pk_ctsk->task;
 
-  _Thread_Enable_dispatch();
-  return E_OK;
+  _ITRON_return_errorno( E_OK );
 }
 

cpukit/itron/src/cre_tsk.c

@@ -33 +33 @@
 
   /*
-   * Disable dispatching.
-   */
-  
-  _Thread_Disable_dispatch();
-
-  /*
    * Validate Parameters.
    */
   
  if ( pk_ctsk == NULL )
-    _ITRON_return_errorno( E_PAR );
+    return E_PAR;
 
   if ((pk_ctsk->tskatr != TA_ASM ) &&
@@ -55 +49 @@
       (pk_ctsk->tskatr != TA_COP6) &&
       (pk_ctsk->tskatr != TA_COP7))
-    _ITRON_return_errorno( E_RSATR );
+    return E_RSATR;
 
   if (( pk_ctsk->itskpri <= 0 ) || ( pk_ctsk->itskpri >= 256 ))
-    _ITRON_return_errorno( E_PAR );
+    return E_PAR;
   if ( pk_ctsk->task == NULL )
-    _ITRON_return_errorno( E_PAR );
+    return E_PAR;
   if ( pk_ctsk->stksz < 0 )
-    _ITRON_return_errorno( E_PAR );
+    return E_PAR;
   
+  /*
+   * Disable dispatching.
+   */
+  
+  _Thread_Disable_dispatch();
+
   /*
    * allocate the thread.
@@ -107 +107 @@
   the_thread->Start.entry_point = (Thread_Entry) pk_ctsk->task;
 
-  _Thread_Enable_dispatch();
-  return E_OK;
+  _ITRON_return_errorno( E_OK );
 }