Changeset c074ea2e in rtems for c/src/lib/libcpu/powerpc/mpc6xx/mmu/pte121.c

Timestamp:

Feb 20, 2003, 10:07:54 PM (18 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Children:

c494deb8

Parents:

da1100e

Message:

2003-02-20 Till Straumann <strauman@…>

PR 349/bsps

• mpc6xx/exceptions/raw_exception.c, mpc6xx/mmu/bat.c, mpc6xx/mmu/pte121.c, shared/include/cpuIdent.c, shared/include/cpuIdent.h, shared/src/Makefile.am, shared/src/stack.c, shared/src/stackTrace.h, powerpc/registers.h:
  • undo improper 'fix' who broke mpc604r identification
  • fix: 7400 identification PVR value was wrong
  • enhance 'setdbat()' to switch OFF a given BAT if called with 0 size
  • fix: page table support bugfix
  • enhancement: provide routines to take and print stack trace snapshots
  • add definitions for HID1 and DABR SPRs

File:

• c/src/lib/libcpu/powerpc/mpc6xx/mmu/pte121.c (modified) (4 diffs)

c/src/lib/libcpu/powerpc/mpc6xx/mmu/pte121.c

@@ -23 +23 @@
 #include <rtems/bspIo.h>
 #include <libcpu/cpuIdent.h>
+#ifdef  DEBUG_EXC
 #include <bsp.h>
-#ifdef  DEBUG_EXC
 #include <bsp/vectors.h>
 #include <libcpu/raw_exception.h>
@@ -126 +126 @@
 
 /* Horrible Macros */
-#ifdef __rtems
+#ifdef __rtems__
 /* must not use printf until multitasking is up */
 typedef void (*PrintF)(char *,...);
@@ -364 +364 @@
                 return 0; /* misaligned */
 
-        /* This should work on a 604, but I couldn't test (I did
-         * on 750 and 7400). Verify that the TLB invalidation works
+        /* This was tested on 604r, 750 and 7400.
+         * On other CPUs, verify that the TLB invalidation works
          * for a new CPU variant and that it has hardware PTE lookup/
          * TLB replacement before adding it to this list.
@@ -679 +679 @@
 
         v=m=0;
-        for (i=0, pte=pt->base; i<pt->size/sizeof(PTERec); i++,pte++) {
+#if 1
+        /* 10/9/2002: I had machine checks crashing after this loop
+         *            terminated. Maybe caused by speculative loads
+         *            from beyond the valid memory area (since the
+         *            page hash table sits at the top of physical
+         *            memory).
+         *            Very bizarre - the other loops in this file
+         *            seem to be fine. Maybe there is a compiler bug??
+         *            For the moment, I let the loop run backwards...
+         *
+         *                        Also see the comment a couple of lines down.
+         */
+        for (i=pt->size/sizeof(PTERec)-1, pte=pt->base + i; i>=0; i--,pte--)
+#else
+        for (i=0, pte=pt->base; i<pt->size/sizeof(PTERec); i++,pte++)
+#endif
+        {
                 int                             err=0;
                 char                    buf[500];
                 unsigned long   *lp=(unsigned long*)pte;
+#if 0
+                /* If I put this bogus while statement here (the body is
+                 * never reached), the original loop works OK
+                 */
+                while (pte >= pt->base + pt->size/sizeof(PTERec))
+                                /* never reached */;
+#endif
+
                 if ( (*lp & (0xfffff0<<7)) || *(lp+1) & 0xe00 || (pte->v && pte->marked)) {
                         /* check for vsid (without segment bits) == 0, unused bits == 0, valid && marked */