Changeset b568ccb in rtems

Timestamp:

Nov 2, 1999, 8:20:13 PM (21 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.10, 4.11, 4.8, 4.9, 5, master

Children:

dfbfa2b0

Parents:

317a5b5

Message:

The object memfile.o was being included in the miniIMFS even though it
should not have been. This required that IMFS_rmnod be split into
three separate (per file type) routines to avoid dependencies.
In the end, a miniIMFS application is 6K smaller than one using the
full IMFS.

Files:

• c/src/exec/libfs/src/imfs/deviceio.c (modified) (2 diffs)
• c/src/exec/libfs/src/imfs/imfs.h (modified) (16 diffs)
• c/src/exec/libfs/src/imfs/imfs_directory.c (modified) (1 diff)
• c/src/exec/libfs/src/imfs/imfs_handlers_device.c (modified) (1 diff)
• c/src/exec/libfs/src/imfs/imfs_handlers_directory.c (modified) (1 diff)
• c/src/exec/libfs/src/imfs/imfs_handlers_memfile.c (modified) (1 diff)
• c/src/exec/libfs/src/imfs/imfs_rmnod.c (deleted)
• c/src/exec/libfs/src/imfs/imfs_unlink.c (modified) (2 diffs)
• c/src/exec/libfs/src/imfs/memfile.c (modified) (2 diffs)
• c/src/exec/libfs/src/imfs/miniimfs_init.c (modified) (1 diff)
• c/src/lib/libc/Makefile.in (modified) (1 diff)
• c/src/lib/libc/deviceio.c (modified) (2 diffs)
• c/src/lib/libc/imfs.h (modified) (16 diffs)
• c/src/lib/libc/imfs_directory.c (modified) (1 diff)
• c/src/lib/libc/imfs_handlers_device.c (modified) (1 diff)
• c/src/lib/libc/imfs_handlers_directory.c (modified) (1 diff)
• c/src/lib/libc/imfs_handlers_memfile.c (modified) (1 diff)
• c/src/lib/libc/imfs_rmnod.c (deleted)
• c/src/lib/libc/imfs_unlink.c (modified) (2 diffs)
• c/src/lib/libc/memfile.c (modified) (2 diffs)
• c/src/lib/libc/miniimfs_init.c (modified) (1 diff)
• c/src/libfs/src/imfs/deviceio.c (modified) (2 diffs)
• c/src/libfs/src/imfs/imfs.h (modified) (16 diffs)
• c/src/libfs/src/imfs/imfs_directory.c (modified) (1 diff)
• c/src/libfs/src/imfs/imfs_handlers_device.c (modified) (1 diff)
• c/src/libfs/src/imfs/imfs_handlers_directory.c (modified) (1 diff)
• c/src/libfs/src/imfs/imfs_handlers_memfile.c (modified) (1 diff)
• c/src/libfs/src/imfs/imfs_rmnod.c (deleted)
• c/src/libfs/src/imfs/imfs_unlink.c (modified) (2 diffs)
• c/src/libfs/src/imfs/memfile.c (modified) (2 diffs)
• c/src/libfs/src/imfs/miniimfs_init.c (modified) (1 diff)
• cpukit/libfs/src/imfs/deviceio.c (modified) (2 diffs)
• cpukit/libfs/src/imfs/imfs.h (modified) (16 diffs)
• cpukit/libfs/src/imfs/imfs_directory.c (modified) (1 diff)
• cpukit/libfs/src/imfs/imfs_handlers_device.c (modified) (1 diff)
• cpukit/libfs/src/imfs/imfs_handlers_directory.c (modified) (1 diff)
• cpukit/libfs/src/imfs/imfs_handlers_memfile.c (modified) (1 diff)
• cpukit/libfs/src/imfs/imfs_rmnod.c (deleted)
• cpukit/libfs/src/imfs/imfs_unlink.c (modified) (2 diffs)
• cpukit/libfs/src/imfs/memfile.c (modified) (2 diffs)
• cpukit/libfs/src/imfs/miniimfs_init.c (modified) (1 diff)

c/src/exec/libfs/src/imfs/deviceio.c

@@ -18 +18 @@
 #include <rtems.h>
 #include <rtems/libio.h>
+#include "libio_.h"
 
 #include "imfs.h"
@@ -214 +215 @@
  *  This IMFS_stat() is used.
  */
+
+/*
+ *  device_rmnod
+ */
+
+int device_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+
+

c/src/exec/libfs/src/imfs/imfs.h

@@ -309 +309 @@
 );
 
-int IMFS_rmnod(
-  rtems_filesystem_location_info_t  *pathloc       /* IN */
-);
-
 int IMFS_mknod(
   const char                        *path,         /* IN */
@@ -354 +350 @@
   off_t          length             /* IN  */
 );
+
 int imfs_dir_open(
   rtems_libio_t *iop,             /* IN  */
@@ -360 +357 @@
   unsigned32     mode             /* IN  */
 );
+
 int imfs_dir_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int imfs_dir_read(
   rtems_libio_t *iop,              /* IN  */
@@ -368 +367 @@
   unsigned32     count             /* IN  */
 );
+
 int imfs_dir_lseek(
   rtems_libio_t        *iop,              /* IN  */
@@ -373 +373 @@
   int                   whence            /* IN  */
 );
+
 int imfs_dir_fstat(
   rtems_filesystem_location_info_t *loc,         /* IN  */
   struct stat                      *buf          /* OUT */
 );
+
+int imfs_dir_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int memfile_open(
   rtems_libio_t *iop,             /* IN  */
@@ -383 +389 @@
   unsigned32     mode             /* IN  */
 );
+
 int memfile_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int memfile_read(
   rtems_libio_t *iop,             /* IN  */
@@ -391 +399 @@
   unsigned32     count            /* IN  */
 );
+
 int memfile_write(
   rtems_libio_t *iop,             /* IN  */
@@ -396 +405 @@
   unsigned32     count            /* IN  */
 );
+
 int memfile_ioctl(
   rtems_libio_t *iop,             /* IN  */
@@ -401 +411 @@
   void          *buffer           /* IN  */
 );
+
 int memfile_lseek(
   rtems_libio_t        *iop,        /* IN  */
@@ -406 +417 @@
   int                   whence      /* IN  */
 );
+
+int memfile_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int device_open(
   rtems_libio_t *iop,            /* IN  */
@@ -412 +428 @@
   unsigned32     mode            /* IN  */
 );
+
 int device_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int device_read(
   rtems_libio_t *iop,            /* IN  */
@@ -420 +438 @@
   unsigned32     count           /* IN  */
 );
+
 int device_write(
   rtems_libio_t *iop,               /* IN  */
@@ -425 +444 @@
   unsigned32     count              /* IN  */
 );
+
 int device_ioctl(
   rtems_libio_t *iop,               /* IN  */
@@ -430 +450 @@
   void          *buffer             /* IN  */
 );
+
 int device_lseek(
   rtems_libio_t *iop,               /* IN  */
@@ -435 +456 @@
   int            whence             /* IN  */
 );
+
+int device_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int IMFS_utime(
   rtems_filesystem_location_info_t  *pathloc,       /* IN */
@@ -440 +466 @@
   time_t                             modtime        /* IN */
 );
+
 int IMFS_fchmod(
   rtems_filesystem_location_info_t *loc,

c/src/exec/libfs/src/imfs/imfs_directory.c

@@ -270 +270 @@
 }
 
-
+/*
+ *  IMFS_dir_rmnod
+ *
+ *  This routine is available from the optable to remove a node 
+ *  from the IMFS file system.
+ */
+
+int imfs_dir_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * You cannot remove a node that still has children 
+   */
+
+  if ( ! Chain_Is_empty( &the_jnode->info.directory.Entries ) )
+     set_errno_and_return_minus_one( ENOTEMPTY );
+
+  /* 
+   * You cannot remove the file system root node.
+   */
+
+  if ( pathloc->mt_entry->mt_fs_root.node_access == pathloc->node_access )
+     set_errno_and_return_minus_one( EBUSY );
+
+  /* 
+   * You cannot remove a mountpoint.
+   */
+
+   if ( the_jnode->info.directory.mt_fs != NULL )
+     set_errno_and_return_minus_one( EBUSY );          
+ 
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+

c/src/exec/libfs/src/imfs/imfs_handlers_device.c

@@ -35 +35 @@
   NULL,   /* fdatasync */
   NULL,   /* fcntl */
-  IMFS_rmnod
+  device_rmnod
 };

c/src/exec/libfs/src/imfs/imfs_handlers_directory.c

@@ -35 +35 @@
   IMFS_fdatasync,
   IMFS_fcntl,
-  IMFS_rmnod
+  imfs_dir_rmnod
 };
 

c/src/exec/libfs/src/imfs/imfs_handlers_memfile.c

@@ -35 +35 @@
   IMFS_fdatasync,
   IMFS_fcntl,
-  IMFS_rmnod
+  memfile_rmnod
 };

c/src/exec/libfs/src/imfs/imfs_unlink.c

@@ -56 +56 @@
     IMFS_update_ctime( node->info.hard_link.link_node );
     if ( node->info.hard_link.link_node->st_nlink < 1) {
-      result = IMFS_rmnod( &the_link );
+      result = (*loc->handlers->rmnod)( &the_link );
       if ( result != 0 )
         return -1;
@@ -62 +62 @@
   }
 
-  result = IMFS_rmnod( loc );
+  result = (*loc->handlers->rmnod)( &the_link );
 
   return result;

c/src/exec/libfs/src/imfs/memfile.c

@@ -29 +29 @@
 
 #define MEMFILE_STATIC 
-
-/*
- *  Set of operations handlers for operations on memfile entities.
- */
-
-rtems_filesystem_file_handlers_r IMFS_memfile_handlers = {
-  memfile_open,
-  memfile_close,
-  memfile_read,
-  memfile_write,
-  memfile_ioctl,
-  memfile_lseek,
-  IMFS_stat,
-  IMFS_fchmod,
-  memfile_ftruncate,
-  NULL,                /* fpathconf */
-  NULL,                /* fsync */
-  IMFS_fdatasync,
-  IMFS_fcntl
-};
 
 /*
@@ -1057 +1037 @@
 }
 
+
+/*
+ *  memfile_rmnod
+ *
+ *  This routine is available from the optable to remove a node 
+ *  from the IMFS file system.
+ */
+
+int memfile_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    IMFS_memfile_remove( the_jnode );
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+

c/src/exec/libfs/src/imfs/miniimfs_init.c

@@ -38 +38 @@
   IMFS_node_type,
   IMFS_mknod,
-  NULL, /* XXX IMFS_rmnod, */
   NULL, /* XXX IMFS_chown, */
   NULL, /* XXX IMFS_freenodinfo, */

c/src/lib/libc/Makefile.in

@@ -26 +26 @@
 IMFS_C_PIECES = imfs_chown imfs_creat imfs_directory imfs_eval imfs_free \
     imfs_fsunmount imfs_gtkn imfs_init imfs_initsupp imfs_link imfs_mknod \
-    imfs_mount imfs_fchmod imfs_rmnod imfs_unlink imfs_unmount imfs_utime \
+    imfs_mount imfs_fchmod imfs_unlink imfs_unmount imfs_utime \
     imfs_ntype imfs_stat imfs_getchild memfile deviceio imfs_handlers_device \
     imfs_handlers_directory imfs_handlers_memfile imfs_debug imfs_symlink \

c/src/lib/libc/deviceio.c

@@ -18 +18 @@
 #include <rtems.h>
 #include <rtems/libio.h>
+#include "libio_.h"
 
 #include "imfs.h"
@@ -214 +215 @@
  *  This IMFS_stat() is used.
  */
+
+/*
+ *  device_rmnod
+ */
+
+int device_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+
+

c/src/lib/libc/imfs.h

@@ -309 +309 @@
 );
 
-int IMFS_rmnod(
-  rtems_filesystem_location_info_t  *pathloc       /* IN */
-);
-
 int IMFS_mknod(
   const char                        *path,         /* IN */
@@ -354 +350 @@
   off_t          length             /* IN  */
 );
+
 int imfs_dir_open(
   rtems_libio_t *iop,             /* IN  */
@@ -360 +357 @@
   unsigned32     mode             /* IN  */
 );
+
 int imfs_dir_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int imfs_dir_read(
   rtems_libio_t *iop,              /* IN  */
@@ -368 +367 @@
   unsigned32     count             /* IN  */
 );
+
 int imfs_dir_lseek(
   rtems_libio_t        *iop,              /* IN  */
@@ -373 +373 @@
   int                   whence            /* IN  */
 );
+
 int imfs_dir_fstat(
   rtems_filesystem_location_info_t *loc,         /* IN  */
   struct stat                      *buf          /* OUT */
 );
+
+int imfs_dir_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int memfile_open(
   rtems_libio_t *iop,             /* IN  */
@@ -383 +389 @@
   unsigned32     mode             /* IN  */
 );
+
 int memfile_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int memfile_read(
   rtems_libio_t *iop,             /* IN  */
@@ -391 +399 @@
   unsigned32     count            /* IN  */
 );
+
 int memfile_write(
   rtems_libio_t *iop,             /* IN  */
@@ -396 +405 @@
   unsigned32     count            /* IN  */
 );
+
 int memfile_ioctl(
   rtems_libio_t *iop,             /* IN  */
@@ -401 +411 @@
   void          *buffer           /* IN  */
 );
+
 int memfile_lseek(
   rtems_libio_t        *iop,        /* IN  */
@@ -406 +417 @@
   int                   whence      /* IN  */
 );
+
+int memfile_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int device_open(
   rtems_libio_t *iop,            /* IN  */
@@ -412 +428 @@
   unsigned32     mode            /* IN  */
 );
+
 int device_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int device_read(
   rtems_libio_t *iop,            /* IN  */
@@ -420 +438 @@
   unsigned32     count           /* IN  */
 );
+
 int device_write(
   rtems_libio_t *iop,               /* IN  */
@@ -425 +444 @@
   unsigned32     count              /* IN  */
 );
+
 int device_ioctl(
   rtems_libio_t *iop,               /* IN  */
@@ -430 +450 @@
   void          *buffer             /* IN  */
 );
+
 int device_lseek(
   rtems_libio_t *iop,               /* IN  */
@@ -435 +456 @@
   int            whence             /* IN  */
 );
+
+int device_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int IMFS_utime(
   rtems_filesystem_location_info_t  *pathloc,       /* IN */
@@ -440 +466 @@
   time_t                             modtime        /* IN */
 );
+
 int IMFS_fchmod(
   rtems_filesystem_location_info_t *loc,

c/src/lib/libc/imfs_directory.c

@@ -270 +270 @@
 }
 
-
+/*
+ *  IMFS_dir_rmnod
+ *
+ *  This routine is available from the optable to remove a node 
+ *  from the IMFS file system.
+ */
+
+int imfs_dir_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * You cannot remove a node that still has children 
+   */
+
+  if ( ! Chain_Is_empty( &the_jnode->info.directory.Entries ) )
+     set_errno_and_return_minus_one( ENOTEMPTY );
+
+  /* 
+   * You cannot remove the file system root node.
+   */
+
+  if ( pathloc->mt_entry->mt_fs_root.node_access == pathloc->node_access )
+     set_errno_and_return_minus_one( EBUSY );
+
+  /* 
+   * You cannot remove a mountpoint.
+   */
+
+   if ( the_jnode->info.directory.mt_fs != NULL )
+     set_errno_and_return_minus_one( EBUSY );          
+ 
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+

c/src/lib/libc/imfs_handlers_device.c

@@ -35 +35 @@
   NULL,   /* fdatasync */
   NULL,   /* fcntl */
-  IMFS_rmnod
+  device_rmnod
 };

c/src/lib/libc/imfs_handlers_directory.c

@@ -35 +35 @@
   IMFS_fdatasync,
   IMFS_fcntl,
-  IMFS_rmnod
+  imfs_dir_rmnod
 };
 

c/src/lib/libc/imfs_handlers_memfile.c

@@ -35 +35 @@
   IMFS_fdatasync,
   IMFS_fcntl,
-  IMFS_rmnod
+  memfile_rmnod
 };

c/src/lib/libc/imfs_unlink.c

@@ -56 +56 @@
     IMFS_update_ctime( node->info.hard_link.link_node );
     if ( node->info.hard_link.link_node->st_nlink < 1) {
-      result = IMFS_rmnod( &the_link );
+      result = (*loc->handlers->rmnod)( &the_link );
       if ( result != 0 )
         return -1;
@@ -62 +62 @@
   }
 
-  result = IMFS_rmnod( loc );
+  result = (*loc->handlers->rmnod)( &the_link );
 
   return result;

c/src/lib/libc/memfile.c

@@ -29 +29 @@
 
 #define MEMFILE_STATIC 
-
-/*
- *  Set of operations handlers for operations on memfile entities.
- */
-
-rtems_filesystem_file_handlers_r IMFS_memfile_handlers = {
-  memfile_open,
-  memfile_close,
-  memfile_read,
-  memfile_write,
-  memfile_ioctl,
-  memfile_lseek,
-  IMFS_stat,
-  IMFS_fchmod,
-  memfile_ftruncate,
-  NULL,                /* fpathconf */
-  NULL,                /* fsync */
-  IMFS_fdatasync,
-  IMFS_fcntl
-};
 
 /*
@@ -1057 +1037 @@
 }
 
+
+/*
+ *  memfile_rmnod
+ *
+ *  This routine is available from the optable to remove a node 
+ *  from the IMFS file system.
+ */
+
+int memfile_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    IMFS_memfile_remove( the_jnode );
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+

c/src/lib/libc/miniimfs_init.c

@@ -38 +38 @@
   IMFS_node_type,
   IMFS_mknod,
-  NULL, /* XXX IMFS_rmnod, */
   NULL, /* XXX IMFS_chown, */
   NULL, /* XXX IMFS_freenodinfo, */

c/src/libfs/src/imfs/deviceio.c

@@ -18 +18 @@
 #include <rtems.h>
 #include <rtems/libio.h>
+#include "libio_.h"
 
 #include "imfs.h"
@@ -214 +215 @@
  *  This IMFS_stat() is used.
  */
+
+/*
+ *  device_rmnod
+ */
+
+int device_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+
+

c/src/libfs/src/imfs/imfs.h

@@ -309 +309 @@
 );
 
-int IMFS_rmnod(
-  rtems_filesystem_location_info_t  *pathloc       /* IN */
-);
-
 int IMFS_mknod(
   const char                        *path,         /* IN */
@@ -354 +350 @@
   off_t          length             /* IN  */
 );
+
 int imfs_dir_open(
   rtems_libio_t *iop,             /* IN  */
@@ -360 +357 @@
   unsigned32     mode             /* IN  */
 );
+
 int imfs_dir_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int imfs_dir_read(
   rtems_libio_t *iop,              /* IN  */
@@ -368 +367 @@
   unsigned32     count             /* IN  */
 );
+
 int imfs_dir_lseek(
   rtems_libio_t        *iop,              /* IN  */
@@ -373 +373 @@
   int                   whence            /* IN  */
 );
+
 int imfs_dir_fstat(
   rtems_filesystem_location_info_t *loc,         /* IN  */
   struct stat                      *buf          /* OUT */
 );
+
+int imfs_dir_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int memfile_open(
   rtems_libio_t *iop,             /* IN  */
@@ -383 +389 @@
   unsigned32     mode             /* IN  */
 );
+
 int memfile_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int memfile_read(
   rtems_libio_t *iop,             /* IN  */
@@ -391 +399 @@
   unsigned32     count            /* IN  */
 );
+
 int memfile_write(
   rtems_libio_t *iop,             /* IN  */
@@ -396 +405 @@
   unsigned32     count            /* IN  */
 );
+
 int memfile_ioctl(
   rtems_libio_t *iop,             /* IN  */
@@ -401 +411 @@
   void          *buffer           /* IN  */
 );
+
 int memfile_lseek(
   rtems_libio_t        *iop,        /* IN  */
@@ -406 +417 @@
   int                   whence      /* IN  */
 );
+
+int memfile_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int device_open(
   rtems_libio_t *iop,            /* IN  */
@@ -412 +428 @@
   unsigned32     mode            /* IN  */
 );
+
 int device_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int device_read(
   rtems_libio_t *iop,            /* IN  */
@@ -420 +438 @@
   unsigned32     count           /* IN  */
 );
+
 int device_write(
   rtems_libio_t *iop,               /* IN  */
@@ -425 +444 @@
   unsigned32     count              /* IN  */
 );
+
 int device_ioctl(
   rtems_libio_t *iop,               /* IN  */
@@ -430 +450 @@
   void          *buffer             /* IN  */
 );
+
 int device_lseek(
   rtems_libio_t *iop,               /* IN  */
@@ -435 +456 @@
   int            whence             /* IN  */
 );
+
+int device_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int IMFS_utime(
   rtems_filesystem_location_info_t  *pathloc,       /* IN */
@@ -440 +466 @@
   time_t                             modtime        /* IN */
 );
+
 int IMFS_fchmod(
   rtems_filesystem_location_info_t *loc,

c/src/libfs/src/imfs/imfs_directory.c

@@ -270 +270 @@
 }
 
-
+/*
+ *  IMFS_dir_rmnod
+ *
+ *  This routine is available from the optable to remove a node 
+ *  from the IMFS file system.
+ */
+
+int imfs_dir_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * You cannot remove a node that still has children 
+   */
+
+  if ( ! Chain_Is_empty( &the_jnode->info.directory.Entries ) )
+     set_errno_and_return_minus_one( ENOTEMPTY );
+
+  /* 
+   * You cannot remove the file system root node.
+   */
+
+  if ( pathloc->mt_entry->mt_fs_root.node_access == pathloc->node_access )
+     set_errno_and_return_minus_one( EBUSY );
+
+  /* 
+   * You cannot remove a mountpoint.
+   */
+
+   if ( the_jnode->info.directory.mt_fs != NULL )
+     set_errno_and_return_minus_one( EBUSY );          
+ 
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+

c/src/libfs/src/imfs/imfs_handlers_device.c

@@ -35 +35 @@
   NULL,   /* fdatasync */
   NULL,   /* fcntl */
-  IMFS_rmnod
+  device_rmnod
 };

c/src/libfs/src/imfs/imfs_handlers_directory.c

@@ -35 +35 @@
   IMFS_fdatasync,
   IMFS_fcntl,
-  IMFS_rmnod
+  imfs_dir_rmnod
 };
 

c/src/libfs/src/imfs/imfs_handlers_memfile.c

@@ -35 +35 @@
   IMFS_fdatasync,
   IMFS_fcntl,
-  IMFS_rmnod
+  memfile_rmnod
 };

c/src/libfs/src/imfs/imfs_unlink.c

@@ -56 +56 @@
     IMFS_update_ctime( node->info.hard_link.link_node );
     if ( node->info.hard_link.link_node->st_nlink < 1) {
-      result = IMFS_rmnod( &the_link );
+      result = (*loc->handlers->rmnod)( &the_link );
       if ( result != 0 )
         return -1;
@@ -62 +62 @@
   }
 
-  result = IMFS_rmnod( loc );
+  result = (*loc->handlers->rmnod)( &the_link );
 
   return result;

c/src/libfs/src/imfs/memfile.c

@@ -29 +29 @@
 
 #define MEMFILE_STATIC 
-
-/*
- *  Set of operations handlers for operations on memfile entities.
- */
-
-rtems_filesystem_file_handlers_r IMFS_memfile_handlers = {
-  memfile_open,
-  memfile_close,
-  memfile_read,
-  memfile_write,
-  memfile_ioctl,
-  memfile_lseek,
-  IMFS_stat,
-  IMFS_fchmod,
-  memfile_ftruncate,
-  NULL,                /* fpathconf */
-  NULL,                /* fsync */
-  IMFS_fdatasync,
-  IMFS_fcntl
-};
 
 /*
@@ -1057 +1037 @@
 }
 
+
+/*
+ *  memfile_rmnod
+ *
+ *  This routine is available from the optable to remove a node 
+ *  from the IMFS file system.
+ */
+
+int memfile_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    IMFS_memfile_remove( the_jnode );
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+

c/src/libfs/src/imfs/miniimfs_init.c

@@ -38 +38 @@
   IMFS_node_type,
   IMFS_mknod,
-  NULL, /* XXX IMFS_rmnod, */
   NULL, /* XXX IMFS_chown, */
   NULL, /* XXX IMFS_freenodinfo, */

cpukit/libfs/src/imfs/deviceio.c

@@ -18 +18 @@
 #include <rtems.h>
 #include <rtems/libio.h>
+#include "libio_.h"
 
 #include "imfs.h"
@@ -214 +215 @@
  *  This IMFS_stat() is used.
  */
+
+/*
+ *  device_rmnod
+ */
+
+int device_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+
+

cpukit/libfs/src/imfs/imfs.h

@@ -309 +309 @@
 );
 
-int IMFS_rmnod(
-  rtems_filesystem_location_info_t  *pathloc       /* IN */
-);
-
 int IMFS_mknod(
   const char                        *path,         /* IN */
@@ -354 +350 @@
   off_t          length             /* IN  */
 );
+
 int imfs_dir_open(
   rtems_libio_t *iop,             /* IN  */
@@ -360 +357 @@
   unsigned32     mode             /* IN  */
 );
+
 int imfs_dir_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int imfs_dir_read(
   rtems_libio_t *iop,              /* IN  */
@@ -368 +367 @@
   unsigned32     count             /* IN  */
 );
+
 int imfs_dir_lseek(
   rtems_libio_t        *iop,              /* IN  */
@@ -373 +373 @@
   int                   whence            /* IN  */
 );
+
 int imfs_dir_fstat(
   rtems_filesystem_location_info_t *loc,         /* IN  */
   struct stat                      *buf          /* OUT */
 );
+
+int imfs_dir_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int memfile_open(
   rtems_libio_t *iop,             /* IN  */
@@ -383 +389 @@
   unsigned32     mode             /* IN  */
 );
+
 int memfile_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int memfile_read(
   rtems_libio_t *iop,             /* IN  */
@@ -391 +399 @@
   unsigned32     count            /* IN  */
 );
+
 int memfile_write(
   rtems_libio_t *iop,             /* IN  */
@@ -396 +405 @@
   unsigned32     count            /* IN  */
 );
+
 int memfile_ioctl(
   rtems_libio_t *iop,             /* IN  */
@@ -401 +411 @@
   void          *buffer           /* IN  */
 );
+
 int memfile_lseek(
   rtems_libio_t        *iop,        /* IN  */
@@ -406 +417 @@
   int                   whence      /* IN  */
 );
+
+int memfile_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int device_open(
   rtems_libio_t *iop,            /* IN  */
@@ -412 +428 @@
   unsigned32     mode            /* IN  */
 );
+
 int device_close(
   rtems_libio_t *iop             /* IN  */
 );
+
 int device_read(
   rtems_libio_t *iop,            /* IN  */
@@ -420 +438 @@
   unsigned32     count           /* IN  */
 );
+
 int device_write(
   rtems_libio_t *iop,               /* IN  */
@@ -425 +444 @@
   unsigned32     count              /* IN  */
 );
+
 int device_ioctl(
   rtems_libio_t *iop,               /* IN  */
@@ -430 +450 @@
   void          *buffer             /* IN  */
 );
+
 int device_lseek(
   rtems_libio_t *iop,               /* IN  */
@@ -435 +456 @@
   int            whence             /* IN  */
 );
+
+int device_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+);
+
 int IMFS_utime(
   rtems_filesystem_location_info_t  *pathloc,       /* IN */
@@ -440 +466 @@
   time_t                             modtime        /* IN */
 );
+
 int IMFS_fchmod(
   rtems_filesystem_location_info_t *loc,

cpukit/libfs/src/imfs/imfs_directory.c

@@ -270 +270 @@
 }
 
-
+/*
+ *  IMFS_dir_rmnod
+ *
+ *  This routine is available from the optable to remove a node 
+ *  from the IMFS file system.
+ */
+
+int imfs_dir_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * You cannot remove a node that still has children 
+   */
+
+  if ( ! Chain_Is_empty( &the_jnode->info.directory.Entries ) )
+     set_errno_and_return_minus_one( ENOTEMPTY );
+
+  /* 
+   * You cannot remove the file system root node.
+   */
+
+  if ( pathloc->mt_entry->mt_fs_root.node_access == pathloc->node_access )
+     set_errno_and_return_minus_one( EBUSY );
+
+  /* 
+   * You cannot remove a mountpoint.
+   */
+
+   if ( the_jnode->info.directory.mt_fs != NULL )
+     set_errno_and_return_minus_one( EBUSY );          
+ 
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+

cpukit/libfs/src/imfs/imfs_handlers_device.c

@@ -35 +35 @@
   NULL,   /* fdatasync */
   NULL,   /* fcntl */
-  IMFS_rmnod
+  device_rmnod
 };

cpukit/libfs/src/imfs/imfs_handlers_directory.c

@@ -35 +35 @@
   IMFS_fdatasync,
   IMFS_fcntl,
-  IMFS_rmnod
+  imfs_dir_rmnod
 };
 

cpukit/libfs/src/imfs/imfs_handlers_memfile.c

@@ -35 +35 @@
   IMFS_fdatasync,
   IMFS_fcntl,
-  IMFS_rmnod
+  memfile_rmnod
 };

cpukit/libfs/src/imfs/imfs_unlink.c

@@ -56 +56 @@
     IMFS_update_ctime( node->info.hard_link.link_node );
     if ( node->info.hard_link.link_node->st_nlink < 1) {
-      result = IMFS_rmnod( &the_link );
+      result = (*loc->handlers->rmnod)( &the_link );
       if ( result != 0 )
         return -1;
@@ -62 +62 @@
   }
 
-  result = IMFS_rmnod( loc );
+  result = (*loc->handlers->rmnod)( &the_link );
 
   return result;

cpukit/libfs/src/imfs/memfile.c

@@ -29 +29 @@
 
 #define MEMFILE_STATIC 
-
-/*
- *  Set of operations handlers for operations on memfile entities.
- */
-
-rtems_filesystem_file_handlers_r IMFS_memfile_handlers = {
-  memfile_open,
-  memfile_close,
-  memfile_read,
-  memfile_write,
-  memfile_ioctl,
-  memfile_lseek,
-  IMFS_stat,
-  IMFS_fchmod,
-  memfile_ftruncate,
-  NULL,                /* fpathconf */
-  NULL,                /* fsync */
-  IMFS_fdatasync,
-  IMFS_fcntl
-};
 
 /*
@@ -1057 +1037 @@
 }
 
+
+/*
+ *  memfile_rmnod
+ *
+ *  This routine is available from the optable to remove a node 
+ *  from the IMFS file system.
+ */
+
+int memfile_rmnod(
+  rtems_filesystem_location_info_t      *pathloc       /* IN */
+)
+{
+  IMFS_jnode_t *the_jnode;  
+
+  the_jnode = (IMFS_jnode_t *) pathloc->node_access;
+
+  /* 
+   * Take the node out of the parent's chain that contains this node 
+   */
+
+  if ( the_jnode->Parent != NULL ) {
+    Chain_Extract( (Chain_Node *) the_jnode );
+    the_jnode->Parent = NULL;
+  }
+
+  /*
+   * Decrement the link counter and see if we can free the space.
+   */
+
+  the_jnode->st_nlink--;
+  IMFS_update_ctime( the_jnode );
+
+  /*
+   * The file cannot be open and the link must be less than 1 to free.
+   */
+
+  if ( !rtems_libio_is_file_open( the_jnode ) && (the_jnode->st_nlink < 1) ) {
+
+    /* 
+     * Is the rtems_filesystem_current is this node?
+     */
+
+    if ( rtems_filesystem_current.node_access == pathloc->node_access )
+       rtems_filesystem_current.node_access = NULL;
+
+    /*
+     * Free memory associated with a memory file.
+     */
+
+    IMFS_memfile_remove( the_jnode );
+
+    free( the_jnode );
+  }
+
+  return 0;
+
+}
+
+

cpukit/libfs/src/imfs/miniimfs_init.c

@@ -38 +38 @@
   IMFS_node_type,
   IMFS_mknod,
-  NULL, /* XXX IMFS_rmnod, */
   NULL, /* XXX IMFS_chown, */
   NULL, /* XXX IMFS_freenodinfo, */