Changeset b38887a in rtems

Timestamp:

Oct 5, 2018, 11:39:49 AM (14 months ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

master

Children:

8776bb9

Parents:

8352d41

git-author:

Sebastian Huber <sebastian.huber@…> (10/05/18 11:39:49)

git-committer:

Sebastian Huber <sebastian.huber@…> (10/05/18 11:41:06)

Message:

dev/sc16is752: Deal with a baud of zero

Avoid division by zero and instead disable rx/tx in case of a zero baud
value. Problem identified by Coverity Scan.

File:

• cpukit/dev/serial/sc16is752.c (modified) (2 diffs)

cpukit/dev/serial/sc16is752.c

@@ -144 +144 @@
 {
   sc16is752_context *ctx = (sc16is752_context *)base;
-  bool baud_successful;
   rtems_termios_baud_t baud;
 
@@ -150 +149 @@
 
   baud = rtems_termios_baud_to_number(term->c_ospeed);
-  baud_successful = set_baud(ctx, baud);
-  if (!baud_successful){
-    return false;
-  }
-
-  if ((term->c_cflag & CREAD) == 0){
-    ctx->efcr |= SC16IS752_EFCR_RX_DISABLE;
-  } else {
-    ctx->efcr &= ~SC16IS752_EFCR_RX_DISABLE;
+
+  if (baud > 0) {
+    if (!set_baud(ctx, baud)){
+      return false;
+    }
+
+    ctx->efcr &= ~SC16IS752_EFCR_TX_DISABLE;
+
+    if ((term->c_cflag & CREAD) == 0){
+      ctx->efcr |= SC16IS752_EFCR_RX_DISABLE;
+    } else {
+      ctx->efcr &= ~SC16IS752_EFCR_RX_DISABLE;
+    }
+  } else {
+    ctx->efcr |= SC16IS752_EFCR_RX_DISABLE | SC16IS752_EFCR_TX_DISABLE;
   }