Changeset a681285 in rtems

Timestamp:

08/14/02 22:58:30 (21 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.10, 4.11, 4.8, 4.9, 5, master

Children:

5e39823

Parents:

37bb9bf

Message:

2002-08-14 Greg Menke <gregory.menke@…>

• mips-stub.c: Re-debugged a breakpoint problem, zbreak target address was a char * which caused the target instruction to not be fully copied, so the zbreak logic corrupted the original instruction and didn't insert a valid break instruction.

Location:

c/src/lib/libbsp/mips/shared/gdbstub

Files:

• ChangeLog (modified) (2 diffs)
• gdb_if.h (modified) (1 diff)
• mips-stub.c (modified) (1 diff)
• rtems-stub-glue.c (modified) (1 diff)

c/src/lib/libbsp/mips/shared/gdbstub/ChangeLog

@@ -1 @@
-2001-03-08      Joel Sherrill <joel@OARcorp.com>
+2002-08-14      Greg Menke <gregory.menke@gsfc.nasa.gov>
+
+        * mips-stub.c: Re-debugged a breakpoint problem, zbreak target
+        address was a char * which caused the target instruction to not
+        be fully copied, so the zbreak logic corrupted the original 
+        instruction and didn't insert a valid break instruction.
+        
+2002-03-08      Joel Sherrill <joel@OARcorp.com>
 
         * mips-stub.c: Removed warnings.
 
-2001-03-05      Greg Menke <gregory.menke@gsfc.nasa.gov>
+2002-03-05      Greg Menke <gregory.menke@gsfc.nasa.gov>
 
         * mips-stub.c: Debugged & tweaked the gdb command processing,
@@ -16 +23 @@
         * README: Updated.
 
-2001-03-01      Joel Sherrill <joel@OARcorp.com>
+2002-03-01      Joel Sherrill <joel@OARcorp.com>
 
         * ChangeLog: Corrected previous entry. 

c/src/lib/libbsp/mips/shared/gdbstub/gdb_if.h

@@ -172 +172 @@
 #define MEMOPT_WRITEABLE  2
 
+#ifndef NUM_MEMSEGS
 #define NUM_MEMSEGS     10
+#endif
 
 int gdbstub_add_memsegment(unsigned,unsigned,int);

c/src/lib/libbsp/mips/shared/gdbstub/mips-stub.c

@@ -251 +251 @@
 
   /* Location, preserved data */
-  unsigned char *address;
+
+  /* the address pointer, really, really must be a pointer to
+  ** a 32 bit quantity (likely 64 on the R4k), so the full instruction is read &
+  ** written.  Making it a char * as on the i386 will cause 
+  ** the zbreaks to mess up the breakpoint instructions
+  */
+  unsigned *address;
   unsigned instr;
 };

c/src/lib/libbsp/mips/shared/gdbstub/rtems-stub-glue.c

@@ -1393 +1393 @@
 { 
 /*
+** These are the right symbols for the desired addresses,
+** but giving them causes gdb to have fits, so we leave 
+** the reported values as 0.  Doesn't hurt the stub's 
+** operation as far as I've observed.
+*/
+
+/*
   extern unsigned32 _ftext;
   extern unsigned32 _fdata;