Changeset a0b94685 in rtems


Ignore:
Timestamp:
May 14, 1999, 2:43:53 PM (23 years ago)
Author:
Joel Sherrill <joel.sherrill@…>
Branches:
4.10, 4.11, 4.8, 4.9, 5, master
Children:
2bd9383
Parents:
123d4b7d
Message:

Removed check for initialized ID at request of Rosimildo DaSilva?
<rdasilva@…> who encountered random failures in his
port of omniORB2.

Files:
2 edited

Legend:

Unmodified
Added
Removed
  • c/src/exec/posix/src/mutex.c

    r123d4b7d ra0b94685  
    235235    return EINVAL;
    236236
     237  /*
     238   *  This code should eventually be removed. 
     239   *
     240   *  Although the POSIX specification says:
     241   *
     242   *  "Attempting to initialize an already initialized mutex results
     243   *  in undefined behavior."
     244   *
     245   *  Trying to keep the caller from doing the create when *mutex
     246   *  is actually a valid ID causes grief.  All it takes is the wrong
     247   *  value in an uninitialized variable to make this fail.  As best
     248   *  I can tell, RTEMS was the only pthread implementation to choose
     249   *  this option for "undefined behavior" and doing so has created
     250   *  portability problems.  In particular, Rosimildo DaSilva
     251   *  <rdasilva@connecttel.com> saw seemingly random failures in the
     252   *  RTEMS port of omniORB2 when this code was enabled.
     253   *
     254   *  Joel Sherrill <joel@OARcorp.com>     14 May 1999
     255   */
     256
     257 
     258#if 0
    237259  /* avoid infinite recursion on call to this routine in _POSIX_Mutex_Get */
    238260
     
    251273    }
    252274  }
     275#endif
    253276 
    254277  if ( !the_attr->is_initialized )
  • cpukit/posix/src/mutex.c

    r123d4b7d ra0b94685  
    235235    return EINVAL;
    236236
     237  /*
     238   *  This code should eventually be removed. 
     239   *
     240   *  Although the POSIX specification says:
     241   *
     242   *  "Attempting to initialize an already initialized mutex results
     243   *  in undefined behavior."
     244   *
     245   *  Trying to keep the caller from doing the create when *mutex
     246   *  is actually a valid ID causes grief.  All it takes is the wrong
     247   *  value in an uninitialized variable to make this fail.  As best
     248   *  I can tell, RTEMS was the only pthread implementation to choose
     249   *  this option for "undefined behavior" and doing so has created
     250   *  portability problems.  In particular, Rosimildo DaSilva
     251   *  <rdasilva@connecttel.com> saw seemingly random failures in the
     252   *  RTEMS port of omniORB2 when this code was enabled.
     253   *
     254   *  Joel Sherrill <joel@OARcorp.com>     14 May 1999
     255   */
     256
     257 
     258#if 0
    237259  /* avoid infinite recursion on call to this routine in _POSIX_Mutex_Get */
    238260
     
    251273    }
    252274  }
     275#endif
    253276 
    254277  if ( !the_attr->is_initialized )
Note: See TracChangeset for help on using the changeset viewer.