Changeset 997ba1d9 in rtems

Timestamp:

09/16/22 17:07:18 (4 months ago)

Author:

Frank Kühndel <frank.kuehndel@…>

Branches:

master

Children:

1c189e1a

Parents:

c46fbb9

git-author:

Frank Kühndel <frank.kuehndel@…> (09/16/22 17:07:18)

git-committer:

Joel Sherrill <joel@…> (12/02/22 15:32:01)

Message:

tftpDriver.c: Fix Coverity issues

CID 1506523: Unchecked return value from library (CHECKED_RETURN)
CID 1506522: Unchecked return value from library (CHECKED_RETURN)
CID 1437618: Unchecked return value from library (CHECKED_RETURN)

Close #4718

File:

• cpukit/libfs/src/ftpfs/tftpDriver.c (modified) (4 diffs)

cpukit/libfs/src/ftpfs/tftpDriver.c

@@ -526 +526 @@
     /*
      * Send it
-     */
-    sendto (tp->socket, (char *)&msg, len, 0, (struct sockaddr *)to, sizeof *to);
+     *
+     * Ignoring result because error packets are sent once and maybe lost.
+     */
+    (void) sendto (tp->socket, (char *)&msg, len, 0, (struct sockaddr *)to, sizeof *to);
 }
 
@@ -553 +555 @@
         tv.tv_sec = tp->config.first_timeout / 1000L;
         tv.tv_usec = (tp->config.first_timeout % 1000L) * 1000L;
-        setsockopt (tp->socket, SOL_SOCKET, SO_RCVTIMEO, &tv, sizeof tv);
+        /*
+         * Ignoring result because all possible errors indicate wrong
+         * arguments and these arguments are OK as tested by test suite.
+         */
+        (void) setsockopt (tp->socket, SOL_SOCKET, SO_RCVTIMEO, &tv,
+            sizeof tv);
     } else {
         tv.tv_sec = tp->config.timeout / 1000L;
         tv.tv_usec = (tp->config.timeout % 1000L) * 1000L;
-        setsockopt (tp->socket, SOL_SOCKET, SO_RCVTIMEO, &tv, sizeof tv);
+        /*
+         * Ignoring result because all possible errors indicate wrong
+         * arguments and these arguments are OK as tested by test suite.
+         */
+        (void) setsockopt (tp->socket, SOL_SOCKET, SO_RCVTIMEO, &tv,
+            sizeof tv);
     }
     for (;;) {
@@ -592 +604 @@
         tv.tv_sec = 0;
         tv.tv_usec = 0;
-        setsockopt (tp->socket, SOL_SOCKET, SO_RCVTIMEO, &tv, sizeof tv);
+        /*
+         * Ignoring result because all possible errors indicate wrong
+         * arguments and these arguments are OK as tested by test suite.
+         */
+        (void) setsockopt (tp->socket, SOL_SOCKET, SO_RCVTIMEO, &tv,
+            sizeof tv);
     }
     return len;
@@ -725 +742 @@
          * Send it. Errors during send will not matter for this last ACK.
          */
-        sendto (
+        (void) sendto (
             tp->socket,
             send_buf,