Changeset 8cacceb in rtems

Timestamp:

May 14, 2013, 11:23:10 AM (8 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

4.11, 5, master

Children:

2f6108f9

Parents:

42eee51

git-author:

Sebastian Huber <sebastian.huber@…> (05/14/13 11:23:10)

git-committer:

Sebastian Huber <sebastian.huber@…> (05/29/13 09:06:07)

Message:

smp: Delete bsp_smp_secondary_cpu_initialize()

Do not call bsp_smp_secondary_cpu_initialize() in
rtems_smp_secondary_cpu_initialize(). This allows more flexibilty in
the BSP low-level code. Specify context requirements for a call to
rtems_smp_secondary_cpu_initialize().

Files:

• c/src/lib/libbsp/i386/shared/smp/smp-imps.c (modified) (4 diffs)
• c/src/lib/libbsp/shared/smp/smp_stub.c (modified) (1 diff)
• c/src/lib/libbsp/sparc/leon3/smp/smp_leon3.c (modified) (2 diffs)
• cpukit/score/include/rtems/bspsmp.h (modified) (1 diff)
• cpukit/score/src/smp.c (modified) (1 diff)

c/src/lib/libbsp/i386/shared/smp/smp-imps.c

@@ -200 +200 @@
 extern unsigned imps_lapic_addr;
 
+static void secondary_cpu_initialize(void);
+
 /*
  *  MPS checksum function
@@ -270 +272 @@
   );
 
-  reset[1] = (uint32_t)rtems_smp_secondary_cpu_initialize;
+  reset[1] = (uint32_t)secondary_cpu_initialize;
   reset[2] = (uint32_t)_Per_CPU_Information[apicid].interrupt_stack_high;
 
@@ -793 +795 @@
 
 /* pc386 specific initialization */
-void bsp_smp_secondary_cpu_initialize(int cpu)
+static void secondary_cpu_initialize(void)
 {
   int apicid;
@@ -805 +807 @@
   enable_sse();
 #endif
+
+  rtems_smp_secondary_cpu_initialize();
 }
 

c/src/lib/libbsp/shared/smp/smp_stub.c

@@ -15 +15 @@
 #include <rtems/bspsmp.h>
 #include <stdlib.h>
-
-void bsp_smp_secondary_cpu_initialize(int cpu)
-{
-}
 
 uint32_t bsp_smp_initialize( uint32_t configured_cpu_count )

c/src/lib/libbsp/sparc/leon3/smp/smp_leon3.c

@@ -42 +42 @@
 }
 
-void bsp_smp_secondary_cpu_initialize(int cpu)
+static void leon3_secondary_cpu_initialize(void)
 {
+  int cpu = bsp_smp_processor_id();
+
   sparc_leon3_set_cctrl( 0x80000F );
   LEON_Unmask_interrupt(LEON3_MP_IRQ);
   LEON3_IrqCtrl_Regs->mask[cpu] |= 1 << LEON3_MP_IRQ;
+
+  rtems_smp_secondary_cpu_initialize();
 }
 
@@ -90 +94 @@
     bsp_ap_stack = _Per_CPU_Information[cpu].interrupt_stack_high -
                       CPU_MINIMUM_STACK_FRAME_SIZE;
-    bsp_ap_entry = rtems_smp_secondary_cpu_initialize;
+    bsp_ap_entry = leon3_secondary_cpu_initialize;
 
     LEON3_IrqCtrl_Regs->mpstat = 1 << cpu;

cpukit/score/include/rtems/bspsmp.h

@@ -120 +120 @@
 
 /**
- *  This method is invoked by @ref rtems_smp_secondary_cpu_initialize
- *  to allow the BSP to perform some intialization.  The @a cpu
- *  parameter indicates the secondary CPU that the code is executing on
- *  and is currently being initialized.
+ * @brief Performs high-level initialization of a secondary CPU and runs the
+ * application threads.
  *
- *  @note This is called by @ref rtems_smp_secondary_cpu_initialize.
+ * The low-level initialization code must call this function to hand over the
+ * control of this processor to RTEMS.  Interrupts must be disabled.  It must
+ * be possible to send inter-processor interrupts to this processor.  Since
+ * interrupts are disabled the inter-processor interrupt delivery is postponed
+ * until interrupts are enabled the first time.  This is usually a side-effect
+ * of the context switch to the first thread.
+ *
+ * The pre-requisites for the call to this function are
+ * - disabled interrupts,
+ * - reception of inter-processor interrupts is possible,
+ * - a valid stack pointer and enough stack space,
+ * - a valid code memory, and
+ * - a valid BSS section.
+ *
+ * This function must not be called by the main processor.
  */
-void bsp_smp_secondary_cpu_initialize(int cpu);
-
-/**
- *  @brief Initialize secondary CPU and coordinates.
- *
- *  This method is the C entry point which secondary CPUs should
- *  arrange to call.  It performs OS initialization for the secondary
- *  CPU and coordinates bring it to a useful state.
- *
- *  @note This is provided by RTEMS.
- */
-void rtems_smp_secondary_cpu_initialize(void);
+void rtems_smp_secondary_cpu_initialize( void );
 
 /**

cpukit/score/src/smp.c

@@ -56 +56 @@
 
   cpu = bsp_smp_processor_id();
-
-  _ISR_Disable_on_this_core( level );
-  bsp_smp_secondary_cpu_initialize(cpu);
 
   /*