Changeset 8230a329 in rtems

Timestamp:

09/15/17 11:24:51 (6 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

5, master

Children:

c030edd

Parents:

3b47ce73

git-author:

Sebastian Huber <sebastian.huber@…> (09/15/17 11:24:51)

git-committer:

Sebastian Huber <sebastian.huber@…> (09/15/17 11:57:53)

Message:

posix: Allow PTHREAD_PROCESS_SHARED for barriers

Close #3126.

Files:

• cpukit/posix/src/pbarrierinit.c (modified) (2 diffs)
• testsuites/psxtests/psxbarrier01/psxbarrier01.scn (modified) (3 diffs)
• testsuites/psxtests/psxbarrier01/test.c (modified) (1 diff)

cpukit/posix/src/pbarrierinit.c

@@ -26 +26 @@
 #include <rtems/system.h>
 #include <rtems/posix/barrierimpl.h>
+#include <rtems/posix/posixapi.h>
 
 /*
@@ -79 +80 @@
     return EINVAL;
 
-  switch ( the_attr->process_shared ) {
-    case PTHREAD_PROCESS_PRIVATE:    /* only supported values */
-      break;
-    case PTHREAD_PROCESS_SHARED:
-    default:
-      return EINVAL;
+  if ( !_POSIX_Is_valid_pshared( the_attr->process_shared ) ) {
+    return EINVAL;
   }
 

testsuites/psxtests/psxbarrier01/psxbarrier01.scn

@@ -1 @@
-*** POSIX BARRIER TEST 01 ***
+*** BEGIN OF TEST PSXBARRIER 1 ***
 pthread_barrierattr_init( NULL ) -- EINVAL
 pthread_barrierattr_setpshared( NULL, private ) -- EINVAL
@@ -20 +20 @@
 pthread_barrierattr_init( &attr ) -- OK
 pthread_barrier_init( &barrier, &attr, 0 ) -- EINVAL
+pthread_barrier_init( &barrier, &attr, 1 ) -- EINVAL
+pthread_barrierattr_setpshared( &attr, shared ) -- OK
+pthread_barrier_init( &barrier, &attr, 1 ) -- OK
+pthread_barrier_destroy( &barrier ) -- OK
 pthread_barrier_init( &barrier, NULL, 1 ) -- OK
 pthread_barrier_init( &barrier, NULL, 1 ) -- EAGAIN
@@ -39 +43 @@
 pthread_barrier_wait - 0x0b010002 released
 pthread_barrier_wait - 0x0b010001 released
-*** END OF POSIX BARRIER TEST 01 ***
+*** END OF TEST PSXBARRIER 1 ***

testsuites/psxtests/psxbarrier01/test.c

@@ -162 +162 @@
   rtems_test_assert( status == EINVAL );
 
+  puts( "pthread_barrier_init( &barrier, &attr, 1 ) -- EINVAL" );
+  attr.process_shared = -1;
+  status = pthread_barrier_init( &barrier, &attr, 1 );
+  rtems_test_assert( status == EINVAL );
+
+  puts( "pthread_barrierattr_setpshared( &attr, shared ) -- OK" );
+  status = pthread_barrierattr_setpshared( &attr, PTHREAD_PROCESS_SHARED );
+  rtems_test_assert( status == 0 );
+
+  puts( "pthread_barrier_init( &barrier, &attr, 1 ) -- OK" );
+  status = pthread_barrier_init( &barrier, &attr, 1 );
+  rtems_test_assert( status == 0 );
+
+  puts( "pthread_barrier_destroy( &barrier ) -- OK" );
+  status = pthread_barrier_destroy( &barrier );
+  rtems_test_assert( status == 0 );
+
   /* allocating too many */
   puts( "pthread_barrier_init( &barrier, NULL, 1 ) -- OK" );