Changeset 7ee59313 in rtems for bsps/arm/csb336/clock

Timestamp:

06/01/18 05:11:12 (5 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

5, master

Children:

196ce18

Parents:

718a84af

git-author:

Sebastian Huber <sebastian.huber@…> (06/01/18 05:11:12)

git-committer:

Sebastian Huber <sebastian.huber@…> (06/27/18 06:58:16)

Message:

Remove Clock_driver_support_shutdown_hardware()

The aim of this clock driver hook was to stop clock tick interrupts at
some late point in the exit() procedure.

The use of atexit() pulls in malloc() which pulls in errno. It is
incompatible with the intention of the
CONFIGURE_DISABLE_NEWLIB_REENTRANCY configuration option.

The exit() function must be called from thread context, so accompanied
clock tick interrupts should cause no harm. On the contrary, someone
may assume a normal operating system operation, e.g. working timeouts.

Remove the Clock_driver_support_shutdown_hardware() clock driver hook.

Close #3436.

File:

• bsps/arm/csb336/clock/clockdrv.c (modified) (1 diff)

bsps/arm/csb336/clock/clockdrv.c

@@ -83 +83 @@
 
 /**
- * Do whatever you need to shut the clock down and remove the
- * interrupt handler. Since this normally only gets called on
- * RTEMS shutdown, you may not need to do anything other than
- * remove the ISR.
- */
-#define Clock_driver_support_shutdown_hardware()                        \
-  do {                                                                  \
-    /* Disable timer */ \
-    MC9328MXL_TMR1_TCTL = 0; \
-    BSP_remove_rtems_irq_handler(&clock_isr_data);                  \
-  } while (0)
-
-/**
  * Enables clock interrupt.
  *