Changeset 78dabb69 in rtems

Timestamp:

Oct 26, 2007, 7:44:10 PM (13 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.10, 4.11, 4.9, 5, master

Children:

0e87deaa

Parents:

327b0020

Message:

2007-10-26 Joel Sherrill <joel.sherrill@…>

• score/Makefile.am, score/include/rtems/score/thread.h, score/inline/rtems/score/thread.inl: No longer inline _Thread_Get. It resulted in unnessary code explosion, many uncovered paths when looking at binary executable coverage, and only optimized getting self. Id translations were still getting pushed to a subroutine call to _Objects_Get. Later the non-inlined version can be further optimized to get Ids in range for the current API, then self, then look at other APIs.
• score/src/threadget.c: New file.

Location:

cpukit

Files:

• ChangeLog (modified) (1 diff)
• score/Makefile.am (modified) (1 diff)
• score/include/rtems/score/thread.h (modified) (1 diff)
• score/inline/rtems/score/thread.inl (modified) (1 diff)
• score/src/threadget.c (added)

cpukit/ChangeLog

@@ +1 @@
+2007-10-26      Joel Sherrill <joel.sherrill@OARcorp.com>
+
+        * score/Makefile.am, score/include/rtems/score/thread.h,
+        score/inline/rtems/score/thread.inl: No longer inline _Thread_Get. It
+        resulted in unnessary code explosion, many uncovered paths when
+        looking at binary executable coverage, and only optimized getting
+        self. Id translations were still getting pushed to a subroutine call
+        to _Objects_Get. Later the non-inlined version can be further
+        optimized to get Ids in range for the current API, then self, then
+        look at other APIs.
+        * score/src/threadget.c: New file.
+
 2007-10-26      Thomas Doerfler <Thomas.Doerfler@embedded-brains.de>
 

cpukit/score/Makefile.am

@@ -127 +127 @@
     src/threadclearstate.c src/threadclose.c src/threadcreateidle.c \
     src/threaddelayended.c src/threaddispatch.c src/threadevaluatemode.c \
-    src/threadhandler.c src/threadidlebody.c \
+    src/threadget.c src/threadhandler.c src/threadidlebody.c \
     src/threadinitialize.c src/threadloadenv.c src/threadready.c \
     src/threadresettimeslice.c src/threadreset.c src/threadrestart.c \

cpukit/score/include/rtems/score/thread.h

@@ -757 +757 @@
 );
 
+/**
+ *  This function maps thread IDs to thread control
+ *  blocks.  If ID corresponds to a local thread, then it
+ *  returns the_thread control pointer which maps to ID
+ *  and location is set to OBJECTS_LOCAL.  If the thread ID is
+ *  global and resides on a remote node, then location is set
+ *  to OBJECTS_REMOTE, and the_thread is undefined.
+ *  Otherwise, location is set to OBJECTS_ERROR and
+ *  the_thread is undefined.
+ *
+ *  @note  The performance of many RTEMS services depends upon
+ *         the quick execution of the "good object" path in this
+ *         routine.  If there is a possibility of saving a few
+ *         cycles off the execution time, this routine is worth
+ *         further optimization attention.
+ */
+Thread_Control *_Thread_Get (
+  Objects_Id         id,
+  Objects_Locations *location
+);
+
 #ifndef __RTEMS_APPLICATION__
 #include <rtems/score/thread.inl>

cpukit/score/inline/rtems/score/thread.inl

@@ -255 +255 @@
 }
 
-/**
- *  This function maps thread IDs to thread control
- *  blocks.  If ID corresponds to a local thread, then it
- *  returns the_thread control pointer which maps to ID
- *  and location is set to OBJECTS_LOCAL.  If the thread ID is
- *  global and resides on a remote node, then location is set
- *  to OBJECTS_REMOTE, and the_thread is undefined.
- *  Otherwise, location is set to OBJECTS_ERROR and
- *  the_thread is undefined.
- *
- *  @note  The performance of many RTEMS services depends upon
- *         the quick execution of the "good object" path in this
- *         routine.  If there is a possibility of saving a few
- *         cycles off the execution time, this routine is worth
- *         further optimization attention.
- */
-
-RTEMS_INLINE_ROUTINE Thread_Control *_Thread_Get (
-  Objects_Id         id,
-  Objects_Locations *location
-)
-{
-  uint32_t             the_api;
-  uint32_t             the_class;
-  Objects_Information *information;
-  Thread_Control      *tp = (Thread_Control *) 0;
- 
-  if ( _Objects_Are_ids_equal( id, OBJECTS_ID_OF_SELF ) ) {
-    _Thread_Disable_dispatch();
-    *location = OBJECTS_LOCAL;
-    tp = _Thread_Executing;
-    goto done;
-  }
- 
-  the_api = _Objects_Get_API( id );
-  if ( the_api && the_api > OBJECTS_APIS_LAST ) {
-    *location = OBJECTS_ERROR;
-    goto done;
-  }
-  
-  the_class = _Objects_Get_class( id );
-  if ( the_class != 1 ) {       /* threads are always first class :) */
-    *location = OBJECTS_ERROR;
-    goto done;
-  }
- 
-  information = _Objects_Information_table[ the_api ][ the_class ];
- 
-  if ( !information ) {
-    *location = OBJECTS_ERROR;
-    goto done;
-  }
- 
-  tp = (Thread_Control *) _Objects_Get( information, id, location );
- 
-done:
-  return tp;
-}
-
-
 /** @brief _Thread_Is_proxy_blocking
  *