Changeset 766ed7c in rtems for c/src/libnetworking/rtems/rtems_syscall.c

Timestamp:

09/29/98 12:15:08 (25 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.10, 4.11, 4.8, 4.9, 5, master

Children:

21bfd93

Parents:

d7fcc1d

Message:

Patch from Eric Norum <eric@…>:

Remember the test to see if a socket could be read and written at
the same time by two different tasks? I discovered that if both
tasks attempt to close the socket a panic can occur from inside the
BSD code.

Closing the same socket twice from two different threads is
certainly an error, but a panic is not the greatest error reporting
method :-)

The following small change to the socket close routine should reduce
the chances of the panic.

File:

• c/src/libnetworking/rtems/rtems_syscall.c (modified) (1 diff)

c/src/libnetworking/rtems/rtems_syscall.c

@@ -684 +684 @@
                 return -1;
         }
-        error = soclose (so);
         i = rtems_file_descriptor_base(fd);
         fdsock[i].indexFreeNext = indexFreeHead;;
         indexFreeHead = i;
-        if (error) {
-                errno = error;
-                rtems_bsdnet_semaphore_release ();
-                return -1;
-        }
-        rtems_bsdnet_semaphore_release ();
+        error = soclose (so);
+        rtems_bsdnet_semaphore_release ();
+        if (error) {
+                errno = error;
+                return -1;
+        }
         return 0;
 }