Changeset 66e83e0e in rtems-libbsd

Timestamp:

May 19, 2017, 7:47:45 AM (3 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

b96abfd647154f10ea8f7fac68e25676636eded5, 13421d06177df03916665bb2f3a7fcadc51a951b, d964a6703c705cc92fd053bcefc08bb3b6baa0e2, b1e67a2bdc575f7f6e0af4922d7adb91545827ca

Children:

9da83e7

Parents:

1908686

git-author:

Sebastian Huber <sebastian.huber@…> (05/19/17 07:47:45)

git-committer:

Sebastian Huber <sebastian.huber@…> (10/23/17 07:24:06)

Message:

soc/qbman: Simplify bman_release()

Get the affine portal only once for the complete transaction.

Signed-off-by: Sebastian Huber <sebastian.huber@…>

File:

• linux/drivers/soc/fsl/qbman/bman.c (modified) (2 diffs)

linux/drivers/soc/fsl/qbman/bman.c

@@ -736 +736 @@
         DPAA_ASSERT(num > 0 && num <= 8);
 
-        do {
+        while (1) {
                 p = get_affine_portal();
                 local_irq_save(irqflags);
@@ -743 +743 @@
                         update_rcr_ci(p, avail);
                 r = bm_rcr_start(&p->p);
+                if (likely(r))
+                        break;
+
                 local_irq_restore(irqflags);
                 put_affine_portal();
-                if (likely(r))
-                        break;
-
+                if (unlikely(--timeout == 0))
+                        return -ETIMEDOUT;
                 udelay(1);
-        } while (--timeout);
-
-        if (unlikely(!timeout))
-                return -ETIMEDOUT;
-
-        p = get_affine_portal();
-        local_irq_save(irqflags);
+        }
+
         /*
          * we can copy all but the first entry, as this can trigger badness