Changeset 66e83e0e in rtems-libbsd

Timestamp:

May 19, 2017, 7:47:45 AM (2 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

647dd08ae2aa69b935c2847ea450fb824322ecae, c6261f97870562d4c797cfb1ff1ba0affb85a916

Children:

9da83e7

Parents:

1908686

git-author:

Sebastian Huber <sebastian.huber@…> (05/19/17 07:47:45)

git-committer:

Sebastian Huber <sebastian.huber@…> (10/23/17 07:24:06)

Message:

soc/qbman: Simplify bman_release()

Get the affine portal only once for the complete transaction.

Signed-off-by: Sebastian Huber <sebastian.huber@…>

File:

• linux/drivers/soc/fsl/qbman/bman.c (modified) (2 diffs)

linux/drivers/soc/fsl/qbman/bman.c

@@ -736 +736 @@
         DPAA_ASSERT(num > 0 && num <= 8);
 
-        do {
+        while (1) {
                 p = get_affine_portal();
                 local_irq_save(irqflags);
@@ -743 +743 @@
                         update_rcr_ci(p, avail);
                 r = bm_rcr_start(&p->p);
+                if (likely(r))
+                        break;
+
                 local_irq_restore(irqflags);
                 put_affine_portal();
-                if (likely(r))
-                        break;
-
+                if (unlikely(--timeout == 0))
+                        return -ETIMEDOUT;
                 udelay(1);
-        } while (--timeout);
-
-        if (unlikely(!timeout))
-                return -ETIMEDOUT;
-
-        p = get_affine_portal();
-        local_irq_save(irqflags);
+        }
+
         /*
          * we can copy all but the first entry, as this can trigger badness