Changeset 610909f in rtems

Timestamp:

11/11/15 11:05:22 (8 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

5, master

Children:

b84a51c

Parents:

5c7bfcf

git-author:

Sebastian Huber <sebastian.huber@…> (11/11/15 11:05:22)

git-committer:

Sebastian Huber <sebastian.huber@…> (11/12/15 07:21:45)

Message:

irq-server: Fix race condition on SMP systems

File:

• c/src/lib/libbsp/shared/src/irq-server.c (modified) (1 diff)

c/src/lib/libbsp/shared/src/irq-server.c

@@ -58 +58 @@
 static void bsp_interrupt_server_trigger(void *arg)
 {
+  rtems_interrupt_lock_context lock_context;
   bsp_interrupt_server_entry *e = arg;
 
   bsp_interrupt_vector_disable(e->vector);
 
+  rtems_interrupt_lock_acquire(&bsp_interrupt_server_lock, &lock_context);
+
   if (rtems_chain_is_node_off_chain(&e->node)) {
-    rtems_interrupt_lock_context lock_context;
-
-    rtems_interrupt_lock_acquire(&bsp_interrupt_server_lock, &lock_context);
     rtems_chain_append_unprotected(&bsp_interrupt_server_chain, &e->node);
-    rtems_interrupt_lock_release(&bsp_interrupt_server_lock, &lock_context);
   } else {
     ++bsp_interrupt_server_errors;
   }
+
+  rtems_interrupt_lock_release(&bsp_interrupt_server_lock, &lock_context);
 
   rtems_event_system_send(bsp_interrupt_server_id, RTEMS_EVENT_SYSTEM_SERVER);