Changeset 511dc4b in rtems for testsuites


Ignore:
Timestamp:
06/19/18 07:09:51 (6 years ago)
Author:
Sebastian Huber <sebastian.huber@…>
Branches:
5, master
Children:
9e3bb45
Parents:
715d616
git-author:
Sebastian Huber <sebastian.huber@…> (06/19/18 07:09:51)
git-committer:
Sebastian Huber <sebastian.huber@…> (06/27/18 06:58:16)
Message:

Rework initialization and interrupt stack support

Statically initialize the interrupt stack area
(_Configuration_Interrupt_stack_area_begin,
_Configuration_Interrupt_stack_area_end, and
_Configuration_Interrupt_stack_size) via <rtems/confdefs.h>. Place the
interrupt stack area in a special section ".rtemsstack.interrupt". Let
BSPs define the optimal placement of this section in their linker
command files (e.g. in a fast on-chip memory).

This change makes makes the CPU_HAS_SOFTWARE_INTERRUPT_STACK and
CPU_HAS_HARDWARE_INTERRUPT_STACK CPU port defines superfluous, since the
low level initialization code has all information available via global
symbols.

This change makes the CPU_ALLOCATE_INTERRUPT_STACK CPU port define
superfluous, since the interrupt stacks are allocated by confdefs.h for
all architectures. There is no need for BSP-specific linker command
file magic (except the section placement), see previous ARM linker
command file as a bad example.

Remove _CPU_Install_interrupt_stack(). Initialize the hardware
interrupt stack in _CPU_Initialize() if necessary (e.g.
m68k_install_interrupt_stack()).

The optional _CPU_Interrupt_stack_setup() is still useful to customize
the registration of the interrupt stack area in the per-CPU information.

The initialization stack can reuse the interrupt stack, since

  • interrupts are disabled during the sequential system initialization, and
  • the boot_card() function does not return.

This stack resuse saves memory.

Changes per architecture:

arm:

  • Mostly replace the linker symbol based configuration of stacks with the standard <rtems/confdefs.h> configuration via CONFIGURE_INTERRUPT_STACK_SIZE. The size of the FIQ, ABT and UND mode stack is still defined via linker symbols. These modes are rarely used in applications and the default values provided by the BSP should be sufficient in most cases.
  • Remove the bsp_processor_count linker symbol hack used for the SMP support. This is possible since the interrupt stack area is now allocated by the linker and not allocated from the heap. This makes some configure.ac stuff obsolete. Remove the now superfluous BSP variants altcycv_devkit_smp and realview_pbx_a9_qemu_smp.

bfin:

  • Remove unused magic linker command file allocation of initialization stack. Maybe a previous linker command file copy and paste problem? In the start.S the initialization stack is set to a hard coded value.

lm32, m32c, mips, nios2, riscv, sh, v850:

  • Remove magic linker command file allocation of initialization stack. Reuse interrupt stack for initialization stack.

m68k:

  • Remove magic linker command file allocation of initialization stack. Reuse interrupt stack for initialization stack.

powerpc:

  • Remove magic linker command file allocation of initialization stack. Reuse interrupt stack for initialization stack.
  • Used dedicated memory region (REGION_RTEMSSTACK) for the interrupt stack on BSPs using the shared linkcmds.base (replacement for REGION_RWEXTRA).

sparc:

  • Remove the hard coded initialization stack. Use the interrupt stack for the initialization stack on the boot processor. This saves 16KiB of RAM.

Update #3459.

Location:
testsuites/sptests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • testsuites/sptests/spfatal07/testcase.h

    r715d616 r511dc4b  
    1010 */
    1111
    12 #include <rtems/bspIo.h>
    13 
    14 /*
    15  *  Way too much stack space.  Should generate a fatal error
    16  *  on the init task create.
    17  */
    18 #define CONFIGURE_HAS_OWN_INIT_TASK_TABLE
    19 #define CONFIGURE_INIT_TASK_STACK_SIZE   RTEMS_MINIMUM_STACK_SIZE
    20 rtems_initialization_tasks_table Initialization_tasks[] = {
    21   { rtems_build_name('I', 'N', 'I', ' '),
    22     RTEMS_MINIMUM_STACK_SIZE,
    23     1,
    24     RTEMS_DEFAULT_ATTRIBUTES,
    25     Init,
    26     RTEMS_DEFAULT_MODES,
    27     0
    28   }
    29 };
    30 #define CONFIGURE_INIT_TASK_TABLE Initialization_tasks
    31 #define CONFIGURE_INIT_TASK_TABLE_SIZE \
    32   sizeof(CONFIGURE_INIT_TASK_TABLE) / sizeof(rtems_initialization_tasks_table)
    33 
    3412#define FATAL_ERROR_TEST_NAME            "7"
    3513#define FATAL_ERROR_DESCRIPTION \
     
    3917          INTERNAL_ERROR_INTERRUPT_STACK_TOO_SMALL
    4018
    41 #if CPU_ALLOCATE_INTERRUPT_STACK == TRUE
    42   #define CONFIGURE_INTERRUPT_STACK_SIZE (STACK_MINIMUM_SIZE - 1)
    43 #endif
     19#define CONFIGURE_INTERRUPT_STACK_SIZE CPU_INTERRUPT_STACK_ALIGNMENT
    4420
    4521void force_error()
    4622{
    47   #if (CPU_ALLOCATE_INTERRUPT_STACK == TRUE)
    48     /* we will not run this far */
    49   #else
    50     printk(
    51       "WARNING - Test not applicable on this target architecture.\n"
    52       "WARNING - Only applicable when CPU_ALLOCATE_INTERRUPT_STACK == TRUE.\n"
    53     );
    54     TEST_END();
    55     rtems_test_exit(0);
    56   #endif
     23  /* we will not run this far */
    5724}
  • testsuites/sptests/spsize/size.c

    r715d616 r511dc4b  
    392392uninitialized += (sizeof _CPU_Null_fp_context);
    393393
    394 #if (CPU_ALLOCATE_INTERRUPT_STACK == TRUE)
    395394uninitialized += (sizeof _CPU_Interrupt_stack_low) +
    396395                 (sizeof _CPU_Interrupt_stack_high);
    397 #endif
    398396
    399397#endif
Note: See TracChangeset for help on using the changeset viewer.