Changeset 4b3251a in rtems

Timestamp:

06/16/16 10:05:42 (7 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

5, master

Children:

d5ff1398

Parents:

57c676c6

git-author:

Sebastian Huber <sebastian.huber@…> (06/16/16 10:05:42)

git-committer:

Sebastian Huber <sebastian.huber@…> (06/16/16 10:46:48)

Message:

score: Fix thread delete race condition on SMP

File:

• cpukit/score/src/threadrestart.c (modified) (2 diffs)

cpukit/score/src/threadrestart.c

@@ -136 +136 @@
 }
 
-static void _Thread_Make_zombie( Thread_Control *the_thread )
+static void _Thread_Add_to_zombie_chain( Thread_Control *the_thread )
 {
   ISR_lock_Context       lock_context;
   Thread_Zombie_control *zombies;
 
+  zombies = &_Thread_Zombies;
+  _ISR_lock_ISR_disable_and_acquire( &zombies->Lock, &lock_context );
+  _Chain_Append_unprotected( &zombies->Chain, &the_thread->Object.Node );
+  _ISR_lock_Release_and_ISR_enable( &zombies->Lock, &lock_context );
+}
+
+static void _Thread_Make_zombie( Thread_Control *the_thread )
+{
   if ( _Thread_Owns_resources( the_thread ) ) {
     _Terminate(
@@ -154 +162 @@
   );
 
-  _Thread_Wake_up_joining_threads( the_thread );
   _Thread_Set_state( the_thread, STATES_ZOMBIE );
   _Thread_queue_Extract_with_proxy( the_thread );
   _Thread_Timer_remove( the_thread );
 
-  zombies = &_Thread_Zombies;
-  _ISR_lock_ISR_disable_and_acquire( &zombies->Lock, &lock_context );
-  _Chain_Append_unprotected( &zombies->Chain, &the_thread->Object.Node );
-  _ISR_lock_Release_and_ISR_enable( &zombies->Lock, &lock_context );
+  /*
+   * Add the thread to the thread zombie chain before we wake up joining
+   * threads, so that they are able to clean up the thread immediately.  This
+   * matters for SMP configurations.
+   */
+  _Thread_Add_to_zombie_chain( the_thread );
+
+  _Thread_Wake_up_joining_threads( the_thread );
 }