Changeset 450c170 in rtems for cpukit/include/rtems/score/priorityimpl.h

Timestamp:

01/28/21 10:35:18 (17 months ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

master

Children:

198e926

Parents:

64189a70

git-author:

Sebastian Huber <sebastian.huber@…> (01/28/21 10:35:18)

git-committer:

Sebastian Huber <sebastian.huber@…> (02/01/21 05:22:20)

Message:

score: Add comments and asserts for clarification

This fix relates to a Coverity issue (NULL_RETURNS).

File:

• cpukit/include/rtems/score/priorityimpl.h (modified) (2 diffs)

cpukit/include/rtems/score/priorityimpl.h

@@ -614 +614 @@
     Priority_Node *min;
 
+    /* The aggregation is non-empty, so the minimum node exists. */
     min = _Priority_Get_minimum_node( aggregation );
+    _Assert( min != NULL );
 
     if ( node->priority < min->priority ) {
@@ -685 +687 @@
   _Priority_Plain_changed( aggregation, node );
 
+  /*
+   * There is at least the changed node in the aggregation, so the minimum node
+   * exists.
+   */
   min = _Priority_Get_minimum_node( aggregation );
+  _Assert( min != NULL );
 
   if ( min->priority != aggregation->Node.priority ) {