Changeset 3bc5984 in rtems-libbsd for rtemsbsd/src/rtems-bsd-rwlock.c

Timestamp:

05/30/12 18:42:49 (11 years ago)

Author:

Jennifer Averett <jennifer.averett@…>

Branches:

4.11, 5, 5-freebsd-12, 6-freebsd-12, freebsd-9.3, master

Children:

569ce65

Parents:

8aecdc0

Message:

Debug of rw_wowned()
This implementation violates the API layer and we should
add a pthread_rwlock_is_rlocked_np() method to the API layer.

File:

• rtemsbsd/src/rtems-bsd-rwlock.c (modified) (3 diffs)

rtemsbsd/src/rtems-bsd-rwlock.c

@@ -40 +40 @@
 /* Necessary to obtain some internal functions */
 #define __RTEMS_VIOLATE_KERNEL_VISIBILITY__
+#include <pthread.h>
+#include <rtems/posix/rwlock.h>
 
 #include <freebsd/machine/rtems-bsd-config.h>
@@ -49 +51 @@
 #include <freebsd/sys/lock.h>
 #include <freebsd/sys/rwlock.h>
-#include <pthread.h>
 
 #ifndef INVARIANTS
@@ -192 +193 @@
 }
 
+/* XXX add pthread_rwlock_is_wlocked_np( id, &wlocked )
+ * XXX    returns 0 or -1 w/error
+ * XXX    wlocked = 1 if write locked
+ * XXX 
+/* XXX add pthread_rwlock_is_rlocked_np( id, &wlocked )
+ * XXX    similar behavior
+ * XXX probably want to add "unlocked" state to RTEMS SuperCore rwlock
+ * XXX
+ * XXX Rationale: This violates the API layering BADLY!!!!!
+ * XXX Consider: Adding pthread_np.h to hold np methods like FreeBSD
+ * XXX           This would avoid polluting pthread.h
+ */
 int
 rw_wowned(struct rwlock *rw)
 {
-  Objects_Locations location;
-  Semaphore_Control *sema = _Semaphore_Get(rw->lock_object.lo_id, &location);
-
-  if (location == OBJECTS_LOCAL && !_Attributes_Is_counting_semaphore(sema->attribute_set)) {
-    int owned = sema->Core_control.mutex.holder_id == rtems_task_self();
-
-    _Thread_Enable_dispatch();
-
-    return owned;
-  } else {
-    _Thread_Enable_dispatch();
-
-    BSD_PANIC("unexpected semaphore location or attributes");
-  }
+  int                   is_locked_for_write = 0;
+  Objects_Locations     location;
+  POSIX_RWLock_Control *the_rwlock;
+
+  the_rwlock = _POSIX_RWLock_Get(&rw->lock_object.lo_id, &location);
+  switch ( location ) {
+
+    case OBJECTS_LOCAL:
+      if (the_rwlock->RWLock.current_state == CORE_RWLOCK_LOCKED_FOR_WRITING)
+        is_locked_for_write = 1;
+      _Thread_Enable_dispatch();
+      return is_locked_for_write;
+
+#if defined(RTEMS_MULTIPROCESSING)
+    case OBJECTS_REMOTE:
+#endif
+    case OBJECTS_ERROR:
+      break;
+  }
+  _Thread_Enable_dispatch();
+
+  BSD_PANIC("unexpected semaphore location or attributes");
 }