Changeset 39f64e08 in rtems for cpukit

Timestamp:
07/28/19 06:25:51 (5 years ago)
Author:
David Gibson <david@…>
Branches:
5, master
Children:
94d5b6ea
Parents:
1a5c324
git-author:
David Gibson <david@…> (07/28/19 06:25:51)
git-committer:
Sebastian Huber <sebastian.huber@…> (03/02/20 06:52:20)
Message:

libfdt: Allow #size-cells of 0

c12b2b0c20eb "libfdt: fdt_address_cells() and fdt_size_cells()" introduced
a bug as it consolidated code between the helpers for getting
#address-cells and #size-cells. Specifically #size-cells is allowed to
be 0, and is frequently found so in practice for /cpus. IEEE1275 only
requires implementations to handle 1..4 for #address-cells, although one
could make a case for #address-cells == #size-cells == 0 being used to
represent a bridge with a single port.

While we're there, it's not totally obvious that the existing implicit
cast of a u32 to int will give the correct results according to strict C,
although it does work in practice. Straighten that up to cast only after
we've made our range checks.

Reported-by: yonghuhaige via https://github.com/dgibson/dtc/issues/28
Signed-off-by: David Gibson <david@…>

(No files)

Note: See TracChangeset for help on using the changeset viewer.