Changeset 1240aade in rtems for cpukit/rtems

Timestamp:

Jan 24, 2017, 1:37:42 PM (3 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

master

Children:

625bd6a

Parents:

6af2221

git-author:

Sebastian Huber <sebastian.huber@…> (01/24/17 13:37:42)

git-committer:

Sebastian Huber <sebastian.huber@…> (01/24/17 13:44:37)

Message:

rtems: Fix _Rate_monotonic_Renew_deadline()

Make _Rate_monotonic_Renew_deadline() static and use proper locking in SMP
configurations.

Update #2795.

Location:

cpukit/rtems

Files:

• include/rtems/rtems/ratemonimpl.h (modified) (1 diff)
• src/ratemonperiod.c (modified) (1 diff)
• src/ratemontimeout.c (modified) (2 diffs)

cpukit/rtems/include/rtems/rtems/ratemonimpl.h

@@ -118 +118 @@
 );
 
-/**
- * @brief Renew the watchdog deadline
- *
- * This routine is prepared for the watchdog timeout to renew its deadline
- * without releasing jobs.
- */
-void _Rate_monotonic_Renew_deadline(
-  Rate_monotonic_Control *the_period,
-  Thread_Control         *owner,
-  ISR_lock_Context       *lock_context
-);
-
 void _Rate_monotonic_Restart(
   Rate_monotonic_Control *the_period,

cpukit/rtems/src/ratemonperiod.c

@@ -119 +119 @@
   _Thread_Priority_update( &queue_context );
   _Thread_Dispatch_enable( cpu_self );
-}
-
-void _Rate_monotonic_Renew_deadline(
-  Rate_monotonic_Control *the_period,
-  Thread_Control         *owner,
-  ISR_lock_Context       *lock_context
-)
-{
-  Per_CPU_Control *cpu_self;
-  uint64_t deadline;
-
-  cpu_self = _Thread_Dispatch_disable_critical( lock_context );
-  _Rate_monotonic_Release( owner, lock_context );
-
-  _ISR_lock_ISR_disable( lock_context );
-  deadline = _Watchdog_Per_CPU_insert_relative(
-    &the_period->Timer,
-    cpu_self,
-    the_period->next_length
-  );
-  the_period->latest_deadline = deadline;
-  _ISR_lock_ISR_enable( lock_context );
-  _Thread_Dispatch_enable( cpu_self );
-
 }
 

cpukit/rtems/src/ratemontimeout.c

@@ -22 +22 @@
 
 #include <rtems/rtems/ratemonimpl.h>
+
+static void _Rate_monotonic_Renew_deadline(
+  Rate_monotonic_Control *the_period,
+  Thread_Control         *owner,
+  ISR_lock_Context       *lock_context
+)
+{
+  uint64_t deadline;
+
+  ++the_period->postponed_jobs;
+  the_period->state = RATE_MONOTONIC_EXPIRED;
+
+  deadline = _Watchdog_Per_CPU_insert_relative(
+    &the_period->Timer,
+    _Per_CPU_Get(),
+    the_period->next_length
+  );
+  the_period->latest_deadline = deadline;
+
+  _Rate_monotonic_Release( the_period, lock_context );
+}
 
 void _Rate_monotonic_Timeout( Watchdog_Control *the_watchdog )
@@ -65 +86 @@
     }
   } else {
-    /*
-     * If the watchdog is timeout, it means there is an additional postponed
-     * job in the next period but it is not available to release now:
-     * Either the current task is still executed, or it is preemptive by the
-     * other higher priority tasks.
-     */
-    the_period->postponed_jobs += 1;
-    the_period->state = RATE_MONOTONIC_EXPIRED;
     _Rate_monotonic_Renew_deadline( the_period, owner, &lock_context );
   }