Changeset 10ec9ae in rtems

Timestamp:

08/05/03 19:06:56 (20 years ago)

Author:

Jennifer Averett <Jennifer.Averett@…>

Children:

3605c4e

Parents:

8ae3c6e8

Message:

2003-08-05 Till Strauman <strauman@…>

PR 436/rtems_misc

• monitor/mon-monitor.c: monitor registered commands list manipulation bugs

Location:

cpukit/libmisc

Files:

• ChangeLog (modified) (1 diff)
• monitor/mon-monitor.c (modified) (2 diffs)

cpukit/libmisc/ChangeLog

@@ +1 @@
+2003-08-05      Till Strauman <strauman@slac.stanford.edu>
+
+        PR 436/rtems_misc
+        * monitor/mon-monitor.c: monitor registered commands list manipulation bugs
+
 2003-07-08      Ralf Corsepius <corsepiu@faw.uni-ulm.de>
 

cpukit/libmisc/monitor/mon-monitor.c

@@ -429 +429 @@
 )
 {
-    rtems_monitor_command_entry_t *p = rtems_registered_commands.next;
+    rtems_monitor_command_entry_t **p =  &rtems_registered_commands.next;
 
     command->next = 0;
 
-    if (rtems_registered_commands.next)
-    {
-        for (; p->next; p = p->next)
-        {
-            if (STREQ(command->command, p->command))
-                return 0;
-        }
-        p->next = command;
-    }
-    else
-        rtems_registered_commands.next = command;
-  
+    while (*p) {
+        if ( STREQ(command->command, (*p)->command) )
+            return 0;
+        p = & (*p)->next;
+    }
+    *p = command;
     return 1;
 }
@@ -453 +447 @@
 )
 {
-    rtems_monitor_command_entry_t *p;
-    rtems_monitor_command_entry_t **p_prev = &rtems_registered_commands.next;
-
-    if (rtems_registered_commands.next)
-    {
-        for (p = rtems_registered_commands.next; p->next; p = p->next)
-        {
-            if (STREQ(command->command, p->command))
-            {
-                *p_prev = p->next;
-                return 1;
-            }
-            p_prev = &p->next;
+    rtems_monitor_command_entry_t **p = & rtems_registered_commands.next;
+                                                                                
+    while (*p) {
+        if ( STREQ(command->command, (*p)->command) ) {
+            *p = (*p)->next;
+            command->next = 0;
+            return 1;
         }
+        p = & (*p)->next;
     }
     return 0;
+
 }