Changeset 0b038bd4 in rtems

Timestamp:

Aug 4, 2018, 8:38:48 AM (2 years ago)

Author:

Sebastian Huber <sebastian.huber@…>

Branches:

5, master

Children:

97417bb

Parents:

b152d33

git-author:

Sebastian Huber <sebastian.huber@…> (08/04/18 08:38:48)

git-committer:

Sebastian Huber <sebastian.huber@…> (08/07/18 05:17:19)

Message:

libblock: Add RTEMS_DEPRECATED

Close #3358.

Files:

• cpukit/include/rtems/blkdev.h (modified) (6 diffs)
• cpukit/include/rtems/diskdevs.h (modified) (8 diffs)
• cpukit/libblock/src/blkdev-imfs.c (modified) (1 diff)
• cpukit/libblock/src/blkdev-ops.c (modified) (1 diff)
• cpukit/libblock/src/blkdev.c (modified) (1 diff)
• cpukit/libblock/src/diskdevs.c (modified) (1 diff)
• testsuites/libtests/block01/init.c (modified) (1 diff)
• testsuites/libtests/block11/init.c (modified) (2 diffs)

cpukit/include/rtems/blkdev.h

@@ -388 +388 @@
   rtems_blkdev_generic_ioctl
 
-/**
- * Generic block device read primitive.
- *
- * Implemented using block device buffer management primitives.
- */
-rtems_device_driver
+/* Use rtems_blkdev_create() instead */
+RTEMS_DEPRECATED rtems_device_driver
 rtems_blkdev_generic_read(
     rtems_device_major_number major,
@@ -400 +396 @@
 );
 
-/**
- * Generic block device write primitive.
- *
- * Implemented using block device buffer management primitives.
- */
-rtems_device_driver
+/* Use rtems_blkdev_create() instead */
+RTEMS_DEPRECATED rtems_device_driver
 rtems_blkdev_generic_write(
     rtems_device_major_number major,
@@ -412 +404 @@
 );
 
-/**
- * Generic block device open primitive.
- *
- * Implemented using block device buffer management primitives.
- */
-rtems_device_driver
+/* Use rtems_blkdev_create() instead */
+RTEMS_DEPRECATED rtems_device_driver
 rtems_blkdev_generic_open(
     rtems_device_major_number major,
@@ -424 +412 @@
 );
 
-/**
- * Generic block device close primitive.
- *
- * Implemented using block device buffer management primitives.
- */
-rtems_device_driver
+/* Use rtems_blkdev_create() instead */
+RTEMS_DEPRECATED rtems_device_driver
 rtems_blkdev_generic_close(
     rtems_device_major_number major,
@@ -436 +420 @@
 );
 
-/**
- * Generic block device IO control primitive.
- *
- * Implemented using block device buffer management primitives.
- */
-rtems_device_driver
+/* Use rtems_blkdev_create() instead */
+RTEMS_DEPRECATED rtems_device_driver
 rtems_blkdev_generic_ioctl(
     rtems_device_major_number major,
@@ -448 +428 @@
 );
 
-/**
- * @brief Generic block operations driver address table.
- */
-extern const rtems_driver_address_table rtems_blkdev_generic_ops;
+/* Use rtems_blkdev_create() instead */
+RTEMS_DEPRECATED extern const rtems_driver_address_table rtems_blkdev_generic_ops;
 
 /** @} */

cpukit/include/rtems/diskdevs.h

@@ -278 +278 @@
 /**@{**/
 
-static inline dev_t rtems_disk_get_device_identifier(
+/* Use fstat() instead */
+RTEMS_DEPRECATED static inline dev_t rtems_disk_get_device_identifier(
   const rtems_disk_device *dd
 )
@@ -285 +286 @@
 }
 
-static inline rtems_device_major_number rtems_disk_get_major_number(
+/* Use fstat() instead */
+RTEMS_DEPRECATED static inline rtems_device_major_number rtems_disk_get_major_number(
   const rtems_disk_device *dd
 )
@@ -292 +294 @@
 }
 
-static inline rtems_device_minor_number rtems_disk_get_minor_number(
+/* Use fstat() instead */
+RTEMS_DEPRECATED static inline rtems_device_minor_number rtems_disk_get_minor_number(
   const rtems_disk_device *dd
 )
@@ -341 +344 @@
 /**@{**/
 
-/**
- * @brief Creates a physical disk with device identifier @a dev.
- *
- * The block size @a block_size must be positive.  The disk will have
- * @a block_count blocks.  The block index starts with zero.  The associated disk
- * device driver will be invoked via the IO control handler @a handler.  A
- * device node will be registered in the file system with absolute path @a
- * name, if @a name is not @c NULL.  This function is usually invoked from a
- * block device driver during initialization when a physical device is detected
- * in the system.  The device driver provides an IO control handler to allow
- * block device operations.
- *
- * @retval RTEMS_SUCCESSFUL Successful operation.
- * @retval RTEMS_NOT_CONFIGURED Cannot lock disk device operation mutex.
- * @retval RTEMS_INVALID_ADDRESS IO control handler is @c NULL.
- * @retval RTEMS_INVALID_NUMBER Block size is invalid.
- * @retval RTEMS_NO_MEMORY Not enough memory.
- * @retval RTEMS_RESOURCE_IN_USE Disk device descriptor is already in use.
- * @retval RTEMS_UNSATISFIED Cannot create device node.
- */
-rtems_status_code rtems_disk_create_phys(
+/* Use rtems_blkdev_create() instead */
+RTEMS_DEPRECATED rtems_status_code rtems_disk_create_phys(
   dev_t dev,
   uint32_t block_size,
@@ -370 +354 @@
 );
 
-/**
- * @brief Creates a logical disk with device identifier @a dev.
- *
- * A logical disk manages a subset of consecutive blocks contained in the
- * physical disk with identifier @a phys.  The start block index of the logical
- * disk device is @a block_begin.  The block count of the logcal disk will be
- * @a block_count.  The blocks must be within the range of blocks managed by
- * the associated physical disk device.  A device node will be registered in
- * the file system with absolute path @a name, if @a name is not @c NULL.  The
- * block size and IO control handler are inherited by the physical disk.
- *
- * @retval RTEMS_SUCCESSFUL Successful operation.
- * @retval RTEMS_NOT_CONFIGURED Cannot lock disk device operation mutex.
- * @retval RTEMS_INVALID_ID Specified physical disk identifier does not
- * correspond to a physical disk.
- * @retval RTEMS_INVALID_NUMBER Begin block or block count are out of range.
- * @retval RTEMS_NO_MEMORY Not enough memory.
- * @retval RTEMS_RESOURCE_IN_USE Disk device descriptor for logical disk
- * identifier is already in use.
- * @retval RTEMS_UNSATISFIED Cannot create device node.
- */
-rtems_status_code rtems_disk_create_log(
+/* Use rtems_blkdev_create_partition() instead */
+RTEMS_DEPRECATED rtems_status_code rtems_disk_create_log(
   dev_t dev,
   dev_t phys,
@@ -399 +363 @@
 );
 
-/**
- * @brief Deletes a physical or logical disk device with identifier @a dev.
- *
- * Marks the disk device as deleted.  When a physical disk device is deleted,
- * all corresponding logical disk devices will marked as deleted too.  Disks
- * that are marked as deleted and have a usage counter of zero will be deleted.
- * The corresponding device nodes will be removed from the file system.  In
- * case of a physical disk deletion the IO control handler will be invoked with
- * a RTEMS_BLKIO_DELETED request.  Disks that are still in use will be deleted
- * upon release.
- *
- * @retval RTEMS_SUCCESSFUL Successful operation.
- * @retval RTEMS_NOT_CONFIGURED Cannot lock disk device operation mutex.
- * @retval RTEMS_INVALID_ID No disk for specified device identifier.
- */
-rtems_status_code rtems_disk_delete(dev_t dev);
-
-/**
- * @brief Returns the disk device descriptor for the device identifier @a dev.
- *
- * Increments usage counter by one.  You should release the disk device
- * descriptor with rtems_disk_release().
- *
- * @return Pointer to the disk device descriptor or @c NULL if no corresponding
- * disk exists.
- */
-rtems_disk_device *rtems_disk_obtain(dev_t dev);
-
-/**
- * @brief Releases the disk device descriptor @a dd.
- *
- * Decrements usage counter by one.
- *
- * @retval RTEMS_SUCCESSFUL Successful operation.
- */
-rtems_status_code rtems_disk_release(rtems_disk_device *dd);
+/*
+ * Use rtems_blkdev_create() or rtems_blkdev_create_partition and unlink()
+ * instead.
+ */
+RTEMS_DEPRECATED rtems_status_code rtems_disk_delete(dev_t dev);
+
+/*
+ * Use rtems_blkdev_create() or rtems_blkdev_create_partition and open()
+ * instead.
+ */
+RTEMS_DEPRECATED rtems_disk_device *rtems_disk_obtain(dev_t dev);
+
+/*
+ * Use rtems_blkdev_create() or rtems_blkdev_create_partition and close()
+ * instead.
+ */
+RTEMS_DEPRECATED rtems_status_code rtems_disk_release(rtems_disk_device *dd);
 
 /** @} */
@@ -443 +388 @@
 /**@{**/
 
-/**
- * @brief Initializes the disk device management.
- *
- * This functions returns successful if the disk device management is already
- * initialized.  There is no protection against concurrent access.
- *
- * @retval RTEMS_SUCCESSFUL Successful initialization.
- * @retval RTEMS_NO_MEMORY Not enough memory or no semaphore available.
- * @retval RTEMS_UNSATISFIED Block device buffer initialization failed.
- */
-rtems_status_code rtems_disk_io_initialize(void);
-
-/**
- * @brief Releases all resources allocated for disk device management.
- *
- * There is no protection against concurrent access.  If parts of the system
- * are still in use the behaviour is undefined.
- *
- * @retval RTEMS_SUCCESSFUL Successful operation.
- */
-rtems_status_code rtems_disk_io_done(void);
+/* Just remove calls to this function */
+RTEMS_DEPRECATED rtems_status_code rtems_disk_io_initialize(void);
+
+/* Just remove calls to this function */
+RTEMS_DEPRECATED rtems_status_code rtems_disk_io_done(void);
 
 /** @} */
@@ -469 +398 @@
 /** @} */
 
-/**
- * @brief Disk device iterator.
- *
- * Returns the next disk device descriptor with a device identifier larger than
- * @a dev.  If there is no such device, @c NULL will be returned.  Use minus
- * one to start the search.
- *
- * @code
- * rtems_status_code sc = RTEMS_SUCCESSFUL;
- * rtems_disk_device *dd = (dev_t) -1;
- *
- * while (sc == RTEMS_SUCCESSFUL && (dd = rtems_disk_next(dev)) != NULL) {
- *   dev = rtems_disk_get_device_identifier(dd);
- *   sc = rtems_disk_release(dd);
- * }
- * @endcode
- */
-rtems_disk_device *rtems_disk_next(dev_t dev);
+/*
+ * This functionality no longer available.  There is no global registration for
+ * disk devices.
+ */
+RTEMS_DEPRECATED rtems_disk_device *rtems_disk_next(dev_t dev);
 
 /* Internal function, do not use */

cpukit/libblock/src/blkdev-imfs.c

@@ -182 +182 @@
 )
 {
-  rtems_blkdev_imfs_context *ctx =
-    IMFS_generic_get_context_by_location(loc);
-  rtems_disk_device *dd = &ctx->dd;
-
-  buf->st_rdev = rtems_disk_get_device_identifier(dd);
+  rtems_blkdev_imfs_context *ctx;
+  rtems_disk_device *dd;
+  IMFS_jnode_t *node;
+
+  ctx = IMFS_generic_get_context_by_location(loc);
+  dd = &ctx->dd;
+
   buf->st_blksize = rtems_disk_get_block_size(dd);
   buf->st_blocks = rtems_disk_get_block_count(dd);
+
+  node = loc->node_access;
+  buf->st_rdev = IMFS_generic_get_device_identifier_by_node(node);
 
   return IMFS_stat(loc, buf);

cpukit/libblock/src/blkdev-ops.c

@@ -23 +23 @@
 #include <rtems/blkdev.h>
 
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 const rtems_driver_address_table rtems_blkdev_generic_ops = {
         .initialization_entry = NULL,

cpukit/libblock/src/blkdev.c

@@ -24 +24 @@
 #include "rtems/diskdevs.h"
 #include "rtems/bdbuf.h"
+
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 
 /* rtems_blkdev_generic_read --

cpukit/libblock/src/diskdevs.c

@@ -28 +28 @@
 #include <rtems/bdbuf.h>
 #include <rtems/thread.h>
+
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 
 #define DISKTAB_INITIAL_SIZE 8

testsuites/libtests/block01/init.c

@@ -33 +33 @@
 #include <rtems/ramdisk.h>
 #include <rtems/diskdevs.h>
+
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 
 const char rtems_test_name[] = "BLOCK 1";

testsuites/libtests/block11/init.c

@@ -11 +11 @@
  *
  *  embedded brains GmbH
- *  Obere Lagerstr. 30
+ *  Dornierstr. 4
  *  82178 Puchheim
  *  Germany
@@ -38 +38 @@
 #include <rtems/malloc.h>
 
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+
 const char rtems_test_name[] = "BLOCK 11";
-
-/* forward declarations to avoid warnings */
-static rtems_task Init(rtems_task_argument argument);
 
 #define ASSERT_SC(sc) rtems_test_assert((sc) == RTEMS_SUCCESSFUL)