Changeset 0643693 in rtems

Timestamp:

Jun 11, 1999, 2:06:13 PM (22 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.10, 4.11, 4.8, 4.9, 5, master

Children:

a6f3cff

Parents:

9a6d32b

Message:

Patch from Eric Norum <eric@…> to fix bug reported by
Ian Lance Taylor <ian@…>:

Ian Lance Taylor wrote:

In rtems-19990528, sbwait sets SB_WAIT in sb_flags. sowakeup checks
it. Why doesn't socket_select set it?

I don't know that this is a bug--I haven't tried to create a test
case. However, it certainly looks odd.

Ian

Yes, there's a bug there. Sorry about that.
It was introduced when I did some cleanup on the sleep/wakeup handling
in rtems_glue.c.

Files:

• c/src/exec/libnetworking/rtems/rtems_select.c (modified) (2 diffs)
• c/src/lib/libnetworking/rtems/rtems_select.c (modified) (2 diffs)
• c/src/libnetworking/rtems/rtems_select.c (modified) (2 diffs)
• cpukit/libnetworking/rtems/rtems_select.c (modified) (2 diffs)

c/src/exec/libnetworking/rtems/rtems_select.c

@@ -57 +57 @@
                 if (soreadable(so))
                         return (1);
+                so->so_rcv.sb_flags |= SB_WAIT;
                 so->so_rcv.sb_sel.si_pid = tid;
                 break;
@@ -63 +64 @@
                 if (sowriteable(so))
                         return (1);
+                so->so_rcv.sb_flags |= SB_WAIT;
                 so->so_snd.sb_sel.si_pid = tid;
                 break;

c/src/lib/libnetworking/rtems/rtems_select.c

@@ -57 +57 @@
                 if (soreadable(so))
                         return (1);
+                so->so_rcv.sb_flags |= SB_WAIT;
                 so->so_rcv.sb_sel.si_pid = tid;
                 break;
@@ -63 +64 @@
                 if (sowriteable(so))
                         return (1);
+                so->so_rcv.sb_flags |= SB_WAIT;
                 so->so_snd.sb_sel.si_pid = tid;
                 break;

c/src/libnetworking/rtems/rtems_select.c

@@ -57 +57 @@
                 if (soreadable(so))
                         return (1);
+                so->so_rcv.sb_flags |= SB_WAIT;
                 so->so_rcv.sb_sel.si_pid = tid;
                 break;
@@ -63 +64 @@
                 if (sowriteable(so))
                         return (1);
+                so->so_rcv.sb_flags |= SB_WAIT;
                 so->so_snd.sb_sel.si_pid = tid;
                 break;

cpukit/libnetworking/rtems/rtems_select.c

@@ -57 +57 @@
                 if (soreadable(so))
                         return (1);
+                so->so_rcv.sb_flags |= SB_WAIT;
                 so->so_rcv.sb_sel.si_pid = tid;
                 break;
@@ -63 +64 @@
                 if (sowriteable(so))
                         return (1);
+                so->so_rcv.sb_flags |= SB_WAIT;
                 so->so_snd.sb_sel.si_pid = tid;
                 break;