Changeset 0139484 in rtems

Timestamp:

Oct 5, 1999, 4:34:20 PM (22 years ago)

Author:

Joel Sherrill <joel.sherrill@…>

Branches:

4.10, 4.11, 4.8, 4.9, 5, master

Children:

7c9cca11

Parents:

6d81ea3

Message:

Patch from Wayne Bullaughey <wayne@…>. Comments follow:

I'm working on code to mount my host based file system on the base file
system (imfs) and have a suggestion for a change to eval.c in the
c/src/lib/libc directory of the 8/20/1999 snapshot. The current version
does not test the result value returned from the evalpath callback (line 47)
in the case where follow_link is true. Attached is my suggested change.
Without this test the node_type callback may be called after evalpath
failed. node_type could set the type to some value other then
RTEMS_FILESYSTEM_HARD_LINK or RTEMS_FILESYSTEM_SYM_LINK but it seems cleaner
to add the check on result.

Files:

• c/src/exec/libcsupport/src/eval.c (modified) (1 diff)
• c/src/lib/libc/eval.c (modified) (1 diff)
• cpukit/libcsupport/src/eval.c (modified) (1 diff)

c/src/exec/libcsupport/src/eval.c

@@ -52 +52 @@
    */
 
-  if ( follow_link ) {
+  if ( (result == 0) && follow_link ) {
 
     if ( !pathloc->ops->node_type )

c/src/lib/libc/eval.c

@@ -52 +52 @@
    */
 
-  if ( follow_link ) {
+  if ( (result == 0) && follow_link ) {
 
     if ( !pathloc->ops->node_type )

cpukit/libcsupport/src/eval.c

@@ -52 +52 @@
    */
 
-  if ( follow_link ) {
+  if ( (result == 0) && follow_link ) {
 
     if ( !pathloc->ops->node_type )