source: rtems/cpukit/include/rtems/posix/rwlockimpl.h @ d8de6b9

5
Last change on this file since d8de6b9 was 2afb22b, checked in by Chris Johns <chrisj@…>, on 12/23/17 at 07:18:56

Remove make preinstall

A speciality of the RTEMS build system was the make preinstall step. It
copied header files from arbitrary locations into the build tree. The
header files were included via the -Bsome/build/tree/path GCC command
line option.

This has at least seven problems:

  • The make preinstall step itself needs time and disk space.
  • Errors in header files show up in the build tree copy. This makes it hard for editors to open the right file to fix the error.
  • There is no clear relationship between source and build tree header files. This makes an audit of the build process difficult.
  • The visibility of all header files in the build tree makes it difficult to enforce API barriers. For example it is discouraged to use BSP-specifics in the cpukit.
  • An introduction of a new build system is difficult.
  • Include paths specified by the -B option are system headers. This may suppress warnings.
  • The parallel build had sporadic failures on some hosts.

This patch removes the make preinstall step. All installed header
files are moved to dedicated include directories in the source tree.
Let @RTEMS_CPU@ be the target architecture, e.g. arm, powerpc, sparc,
etc. Let @RTEMS_BSP_FAMILIY@ be a BSP family base directory, e.g.
erc32, imx, qoriq, etc.

The new cpukit include directories are:

  • cpukit/include
  • cpukit/score/cpu/@RTEMS_CPU@/include
  • cpukit/libnetworking

The new BSP include directories are:

  • bsps/include
  • bsps/@RTEMS_CPU@/include
  • bsps/@RTEMS_CPU@/@RTEMS_BSP_FAMILIY@/include

There are build tree include directories for generated files.

The include directory order favours the most general header file, e.g.
it is not possible to override general header files via the include path
order.

The "bootstrap -p" option was removed. The new "bootstrap -H" option
should be used to regenerate the "headers.am" files.

Update #3254.
  • Property mode set to 100644
File size: 1.3 KB
Line 
1/**
2 * @file
3 *
4 * @brief Inlined Routines from the POSIX RWLock Manager
5 *
6 * This file contains the static inlin implementation of the inlined
7 * routines from the POSIX RWLock Manager.
8 */
9
10/*
11 *  COPYRIGHT (c) 1989-2011.
12 *  On-Line Applications Research Corporation (OAR).
13 *
14 *  The license and distribution terms for this file may be
15 *  found in the file LICENSE in this distribution or at
16 *  http://www.rtems.org/license/LICENSE.
17 */
18
19#ifndef _RTEMS_POSIX_RWLOCKIMPL_H
20#define _RTEMS_POSIX_RWLOCKIMPL_H
21
22#include <rtems/score/corerwlockimpl.h>
23
24#include <errno.h>
25#include <pthread.h>
26
27#ifdef __cplusplus
28extern "C" {
29#endif
30
31#define POSIX_RWLOCK_MAGIC 0x9621dabdUL
32
33typedef struct {
34  unsigned long flags;
35  CORE_RWLock_Control RWLock;
36} POSIX_RWLock_Control;
37
38RTEMS_INLINE_ROUTINE POSIX_RWLock_Control *_POSIX_RWLock_Get(
39  pthread_rwlock_t *rwlock
40)
41{
42  return (POSIX_RWLock_Control *) rwlock;
43}
44
45bool _POSIX_RWLock_Auto_initialization( POSIX_RWLock_Control *the_rwlock );
46
47#define POSIX_RWLOCK_VALIDATE_OBJECT( rw ) \
48  do { \
49    if ( ( rw ) == NULL ) { \
50      return EINVAL; \
51    } \
52    if ( ( (uintptr_t) ( rw ) ^ POSIX_RWLOCK_MAGIC ) != ( rw )->flags ) { \
53      if ( !_POSIX_RWLock_Auto_initialization( rw ) ) { \
54        return EINVAL; \
55      } \
56    } \
57  } while ( 0 )
58
59#ifdef __cplusplus
60}
61#endif
62
63#endif
64/*  end of include file */
Note: See TracBrowser for help on using the repository browser.